upgrade kakarot 0.8.0 on kakarot sepolia #1150
Conversation
| "account_contract_fixture": "0x2c2520d81c315969597b2f7a0189db1b65ec19da02fe40c40d183e2e9bfb3c8", | ||
| "kakarot": "0x7e5e97d10a2db3957687ba0a4bb5afde05bf7468871514af416d70badb711f8", | ||
| "account_contract": "0x3c1081f98ecdd1d320368d2a136191a3fbf02a3e419463d77c3c5aa6dbc99a0", | ||
| "account_contract_fixture": "0x5e823aa6a4468e35903689615b834fe280a1f6a039b22d0d577f551a50cda03", |
There was a problem hiding this comment.
account_contract_fixture EVM Cairo1HelpersFixture are not meant to be declared on prod networks, they're only classes used for tests
There was a problem hiding this comment.
idk, shouldnt be on testnets, only devnets
There was a problem hiding this comment.
because well, currently there is nothing in the DECLARED_CONTRACTS constant to give such information!
You could add a 'only_devnet': bool in (https://github.com/ClementWalter/kakarot/blob/98b26fda32c36f09880ed0c7f44dba7f4d669b61/kakarot_scripts/constants.py#L185)
and filter in https://github.com/ClementWalter/kakarot/blob/98b26fda32c36f09880ed0c7f44dba7f4d669b61/kakarot_scripts/deploy_kakarot.py#L38
There was a problem hiding this comment.
note that it's not been done yet because it was especially made it possible to run the end-to-end tests against any RPC (e.g. starknet testnet), but it's not been used so far
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Resolves #
What is the new behavior?
This change is