Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade kakarot 0.8.0 on kakarot sepolia #1150

Merged
merged 1 commit into from
May 23, 2024
Merged

upgrade kakarot 0.8.0 on kakarot sepolia #1150

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions deployments/kakarot-sepolia/declarations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
{
"kakarot": "0x5fa636d9904ec7b1ac2c50ff36ccbe3d38db666b7fafd4107c68c8333bf0bec",
"account_contract": "0x490cccb64e3917ecf0a80a59d0c3e449766f745c1d6db54e0050f89eb59aba1",
"account_contract_fixture": "0x2c2520d81c315969597b2f7a0189db1b65ec19da02fe40c40d183e2e9bfb3c8",
"kakarot": "0x7e5e97d10a2db3957687ba0a4bb5afde05bf7468871514af416d70badb711f8",
"account_contract": "0x3c1081f98ecdd1d320368d2a136191a3fbf02a3e419463d77c3c5aa6dbc99a0",
"account_contract_fixture": "0x5e823aa6a4468e35903689615b834fe280a1f6a039b22d0d577f551a50cda03",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

account_contract_fixture EVM Cairo1HelpersFixture are not meant to be declared on prod networks, they're only classes used for tests

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why were they declared?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idk, shouldnt be on testnets, only devnets

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because well, currently there is nothing in the DECLARED_CONTRACTS constant to give such information!

You could add a 'only_devnet': bool in (https://github.com/ClementWalter/kakarot/blob/98b26fda32c36f09880ed0c7f44dba7f4d669b61/kakarot_scripts/constants.py#L185)

and filter in https://github.com/ClementWalter/kakarot/blob/98b26fda32c36f09880ed0c7f44dba7f4d669b61/kakarot_scripts/deploy_kakarot.py#L38

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note that it's not been done yet because it was especially made it possible to run the end-to-end tests against any RPC (e.g. starknet testnet), but it's not been used so far

"uninitialized_account": "0x600f6862938312a05a0cfecba0dcaf37693efc9e4075a6adfb62e196022678e",
"EVM": "0x6d15df70c233da830791620414901117c37a3786ef5814632af8c602b7f003b",
"EVM": "0x52f5b74f5d6806f4190b65963eb4b168e0a492441730f3dc120b3fb4b19b5fa",
"OpenzeppelinAccount": "0x6153ccf69fd20f832c794df36e19135f0070d0576144f0b47f75a226e4be530",
"Cairo1Helpers": "0x28ece3751ecf5bdf2d791eb64a65bfb6a8816432b698870dba2f38a36101d58",
"Cairo1HelpersFixture": "0x4e7811d9bbba41193bd3c77d05c16f7aaa55dd1d601686b50f6fa0e3766a712",
Expand Down
Loading