Fix updating of adaptive plugins re: commit 6b6e581. #188
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 6b6e581 modified the adaptive base class to
call it's update() method in beforeTrial rather than
afterTrial. However, beforeTrial is only called on
plugins after beforeTrial is called on the current
block/design object. As a result, the design object
cannot know the new/updated value that should be
assigned to a parameter for the next trial. The design
object therefore (re-)assigns the value from the previous
trial.
This change calls beforeTrial on any adaptive plugins
before calling beforeTrial on the current block/design.