Event metric name v2.x #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-masseau
force-pushed
the
event-metric-name-v1.x
branch
from
baad67b
to
81fe5e4
Compare
evan-masseau
changed the base branch from
event-metric-name-v1.x
to
rel/2.0.0
evan-masseau
added
the
major-release
evan-masseau
force-pushed
the
event-metric-name-v2.x
branch
from
d55608e
to
b03ebcf
Compare
kennyklaviyo
approved these changes
Jan 12, 2024
Include API breaking change to rename argument labels now
evan-masseau
force-pushed
the
event-metric-name-v2.x
branch
from
b03ebcf
to
a068fc1
Compare
evan-masseau
added a commit
that referenced
this pull request
Jan 12, 2024
And rename argument/property labels for event type -> metric Co-authored-by: Evan Masseau <>
evan-masseau
pushed a commit
that referenced
this pull request
Jan 24, 2024
* master: Run staleness check during ET work hours Release version 2.0.0 Documentation: top-level redirect for github pages (#119) Pre-release version 2.0.0-alpha.3 Required for android to target jvm 11 Alpha release 2.0.0-alpha.2 Target SDK 34 and other dependency upgrades (#115) Increment version for pre-release. Leave dokka unchanged, we won't publish docs for prerelease. Remove deprecated EventType and update migration guide. (#109) Change Event.Value to a double (#110) # Conflicts: # build.gradle # docs/index.html # versions.gradle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Finishes the removal of old event names by deleting EventType and renaming some argument labels.
See #107 for first set of changes.
Check List
Changelog / Code Overview
Remove deprecated EventType
Test Plan
Unit tests and test app
Related Issues/Tickets
CHNL-4084