This repository has been archived by the owner on Aug 19, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyunsooda
requested review from
KimKyungup,
aidan-kwon and
jeongkyun-oh
as code owners
March 28, 2022 08:39
kjhman21
previously approved these changes
Mar 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@aidan-kwon @henry-will Please take a look. |
KimKyungup
previously approved these changes
Mar 30, 2022
henry-will
previously approved these changes
Mar 31, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's Good.
hyunsooda
dismissed stale reviews from henry-will, KimKyungup, and kjhman21
via
March 31, 2022 14:13
cc66fce
The name of constant variables was renamed by go-convention. |
hqjang-pepper
previously approved these changes
Apr 4, 2022
kjhman21
reviewed
Apr 4, 2022
`DefaultChildBridgeAccountName`
kjhman21
reviewed
Apr 4, 2022
ehnuje
previously approved these changes
Apr 7, 2022
kjhman21
previously approved these changes
Apr 7, 2022
hqjang-pepper
previously approved these changes
Apr 7, 2022
aidan-kwon
previously approved these changes
Apr 12, 2022
KimKyungup
previously approved these changes
Apr 13, 2022
hyunsooda
dismissed stale reviews from KimKyungup, aidan-kwon, hqjang-pepper, kjhman21, and ehnuje
via
April 14, 2022 05:13
20b4d80
@jeongkyun-oh please, review in your valuable time. |
jeongkyun-oh
approved these changes
Apr 14, 2022
aidan-kwon
approved these changes
Apr 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
bridge_manager_test.go
. Some of the existing error checking checks likeif err != nil
and panics with a log if it goes into that. I think they seem verbose and can be neat by replacing with assertion.Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test
)Related issues
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...