Skip to content
This repository has been archived by the owner on Aug 19, 2024. It is now read-only.

Write DeriveShaImpl to post-Kore genesis block #1716

Merged
merged 2 commits into from
Nov 22, 2022
Merged

Write DeriveShaImpl to post-Kore genesis block #1716

merged 2 commits into from
Nov 22, 2022

Conversation

blukat29
Copy link
Contributor

Proposed changes

  • Genesis blocks with Kore fork enabled, its block.governanceData should contain deriveshaimpl.

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

Further comments

@blukat29 blukat29 mentioned this pull request Nov 22, 2022
Closed
@blukat29 blukat29 self-assigned this Nov 22, 2022
@blukat29 blukat29 added this to the v1.10 (Kore) milestone Nov 22, 2022
@blukat29 blukat29 merged commit 45f1f5b into klaytn:dev Nov 22, 2022
@blukat29 blukat29 deleted the deriveshaimpl-genesis branch July 26, 2023 07:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ian0371 ian0371 ian0371 approved these changes

@jiseongnoh jiseongnoh jiseongnoh approved these changes

@yoomee1313 yoomee1313 yoomee1313 approved these changes

@aidan-kwon aidan-kwon Awaiting requested review from aidan-kwon

@mckim19 mckim19 Awaiting requested review from mckim19

Assignees

@blukat29 blukat29

Labels
None yet
Projects
None yet
Milestone
v1.10.0 (Kore)
Development

Successfully merging this pull request may close these issues.
4 participants
@blukat29 @ian0371 @jiseongnoh @yoomee1313