Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: iPad Support / Layout #22

Closed
grgcombs opened this issue Jan 31, 2011 · 4 comments
Closed

Feature Request: iPad Support / Layout #22

grgcombs opened this issue Jan 31, 2011 · 4 comments

Comments

@grgcombs
Copy link

I've previously done this with TapkuLibrary's Calendar, but I've since run into issues with drawing on 4.2.x. So now I'm trying to scope out how to implement an iPad-specific layout for Kal. To give you an idea of what I have in mind, here's an image:

IB layout, with shadows

The grid view on the top left, the table view on the top right, and a detail view (in my case a uiwebcontroller) at the bottom. Any thoughts? Have you already looked into iPad support for Kal?

@klazuka
Copy link
Owner

klazuka commented Feb 1, 2011

You're on your own for adding iPad support. As of right now, I have no plans to add iPad support to Kal. I simply don't have the time, nor the need. Sorry.

@theonlyyam
Copy link

Hi Kal,

First of all, thanks a lot for your work, its a really nice job and i know it takes time.

I use your library on ipad and it works fine with some minor modification to apply.

I had to extend KalView and KalViewController to make it works properly. The reason is the size of the displayed calendar. It takes the full i pad size (1024x768) because of this line in the KalViewController.loadView method:

 KalView *kalView = [[[KalView alloc] initWithFrame:[[UIScreen mainScreen] applicationFrame] delegate:self logic:logic] autorelease];

So my own KalViewController, who extends yours, looks like this:

@synthesize title, myFrame;

- (void)loadView{
    if (!self.title){
        self.title = myTitle;
    }
    MyKalView *kalView = [[[MyKalView alloc] initWithFrame:myFrame delegate:self logic:super.logic] autorelease];
    self.view = kalView;
}


- (void)dealloc{
    [super dealloc];
    [title release];
}
@end

The idea is simply to give the frame size to the KalView. With this solution, everythings work great, but it works only on simulator. To use it on the device i had to modify the visibility of the "logic" attribut to give it a getter method in your class....

So my question is: Is it possible to add this:

in KalViewController.h @Property(nonatomic,readonly) KalLogic *logic;
in KalViewController.m @synthesize logic;

in your source code? I can do it directly in the source on my local machine but i will break your licence and i will have trouble with my company because of license problems (even if MIT...).

You can notice that i have also remove the tableView because i don't use it. The advantage is to offer more flexibility to the developer, because on ipad it's very common to use splitView with calendar on left side and tableView on right side.

If you need help or idea for new project, don't hesitate to contact me i will be very happy to work with you.

@theonlyyam
Copy link

Another possibility is to have two method "loadView" with one of them who takes a CGRectMake in param to initialize correctly the KalView object. It's a better solution and with less modification....

@klazuka
Copy link
Owner

klazuka commented Apr 5, 2011

As I've mentioned before, I have no plans to add iPad support to Kal. The intent of the project was simply to clone Apple's month calendar on the iPhone. Since I don't have a need for iPad support, I cannot justify the effort nor would I be able to adequately assess its usefulness and correctness.

So, unless someone contributes both (1) a patch to add iPad support and (2) an example iPad app that exercises the new functionality, I will not be adding iPad support to Kal.

There is nothing in the MIT license preventing you from forking Kal.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants