Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding allen & miller data #1

Merged
merged 8 commits into from
Aug 15, 2019

Conversation

joselyn-rodriguez
Copy link
Contributor

No description provided.

@kleinschmidt
Copy link
Owner

Can you also add the citation/description to the README, R/data.R, and the CITATION file?

R/data.R Outdated
@@ -34,6 +34,11 @@ NULL
#' Corpus of conversational speech by Andy Wedel. Age is coded as old (40+) or
#' young (under 40). Includes two measures of local speech rate, syllables
#' per second and total stop length.}
#'
#' \item{allen-miller}{Allen & Miller (1999). Experiment 1 was similar to \code{gva13}
#' and measured VOTs for voiced stops in monosyllabic words. Experiment 2 was the
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

voiced and voiceless right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh right - I thought I had corrected that. Ill fix that now

@kleinschmidt
Copy link
Owner

A few more things: don't include the .DS_store file (that's a macOS thing) and re-run devtools::document() to update the stored document file (and commit that as well).

@kleinschmidt kleinschmidt merged commit 639163d into kleinschmidt:master Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants