Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(web)/extra path to the open notifications and onboarding miniguide #1607

Conversation

nikhilverma360
Copy link
Contributor

@nikhilverma360 nikhilverma360 commented Jun 6, 2024

Examples:
https://v2.kleros.builders/#/#notifications
https://v2.kleros.builders/#/#onboarding

PR-Codex overview

The focus of this PR is to enhance navigation in the web application by adding functionality related to tabs and URL fragments.

Detailed summary

  • Added initialTab prop to ISettings
  • Utilized useLocation and useNavigate in Settings and Template
  • Implemented URL fragment handling in Settings and Template
  • Introduced Onboarding component in DesktopHeader

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • New Features

    • Added navigation handling for onboarding and notifications paths in the header.
    • Updated settings to accept an initial tab based on URL fragments.
  • Enhancements

    • Improved user experience by maintaining onboarding state and initial tab selection based on URL.
  • Bug Fixes

    • Resolved issues with closing popups by ensuring onboarding hash paths are removed correctly.

Copy link

netlify bot commented Jun 6, 2024

Deploy Preview for kleros-v2 ready!

Name Link
🔨 Latest commit b1f62dc
🔍 Latest deploy log https://app.netlify.com/sites/kleros-v2/deploys/666ab1e29666ba000871fcb2
😎 Deploy Preview https://deploy-preview-1607--kleros-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 6, 2024

Deploy Preview for kleros-v2-university ready!

Name Link
🔨 Latest commit b1f62dc
🔍 Latest deploy log https://app.netlify.com/sites/kleros-v2-university/deploys/666ab1e221db5100086cb79f
😎 Deploy Preview https://deploy-preview-1607--kleros-v2-university.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 6, 2024

Deploy Preview for kleros-v2-neo ready!

Name Link
🔨 Latest commit b1f62dc
🔍 Latest deploy log https://app.netlify.com/sites/kleros-v2-neo/deploys/666ab1e22b0b9a0008d7573b
😎 Deploy Preview https://deploy-preview-1607--kleros-v2-neo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

coderabbitai bot commented Jun 6, 2024

Important

Review skipped

Auto reviews are limited to specific labels.

Labels to auto review (1)
  • dependencies

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

web/src/pages/Home/index.tsx Outdated Show resolved Hide resolved
web/src/layout/Header/DesktopHeader.tsx Outdated Show resolved Hide resolved
@kleros kleros deleted a comment from coderabbitai bot Jun 7, 2024
@jaybuidl jaybuidl linked an issue Jun 12, 2024 that may be closed by this pull request
Copy link
Contributor

@alcercu alcercu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codeclimate bot commented Jun 13, 2024

Code Climate has analyzed commit b1f62dc and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarcloud bot commented Jun 13, 2024

@alcercu alcercu added this pull request to the merge queue Jun 13, 2024
Merged via the queue into dev with commit aeecb23 Jun 13, 2024
20 of 22 checks passed
@jaybuidl jaybuidl deleted the feat(web)/Extra-path-to-the-open-Notifications-and-Onboarding-miniguide branch August 1, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extra path to the Notifications modal and Onboarding miniguide
3 participants