Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ORMB python sdk setup.py imports requests before installing it #195

Closed
gbolmier opened this issue Nov 30, 2021 · 0 comments · Fixed by #198
Closed

ORMB python sdk setup.py imports requests before installing it #195

gbolmier opened this issue Nov 30, 2021 · 0 comments · Fixed by #198
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@gbolmier
Copy link
Contributor

Is this a BUG REPORT or FEATURE REQUEST?:

/kind bug

What happened:

setup.py imports git_release module which imports requests before this latter could actually be installed as specified by install_requires:

ormb/extern-sdk/python/setup.py

Lines 33 to 35 in 0aae49a

install_requires=[
"requests"
],

leading to installation failures of ORMB python sdk on systems that don't have the requests package pre-installed

What you expected to happen:

ORMB python sdk installation should not require pre-installed packages

How to reproduce it (as minimally and precisely as possible):

Create a virtual environment without installing requests and then pip install ormb

Anything else we need to know?:
@gaocegege gaocegege added the kind/bug Categorizes issue or PR as related to a bug. label Dec 1, 2021
@gbolmier gbolmier mentioned this issue Dec 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[python-sdk] Remove requests dependency gbolmier/ormb
2 participants
@gaocegege @gbolmier