Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] Make exporting metada optional when exporting the model #40

Open
gaocegege opened this issue Jun 11, 2020 · 3 comments
Open

[feature] Make exporting metada optional when exporting the model #40

gaocegege opened this issue Jun 11, 2020 · 3 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/P1 Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@gaocegege
Copy link
Member

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:

/kind bug
/kind feature

What happened:

Now the metadata will be pulled and stored as orbfile.yaml when we export the model. It should be optional, maybe by flag.

What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:
@gaocegege gaocegege added kind/feature Categorizes issue or PR as related to a new feature. priority/P1 Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Jun 12, 2020
@judgeeeeee judgeeeeee mentioned this issue Jul 20, 2020
Open
@simon-cj
Copy link
Contributor

simon-cj commented Aug 6, 2020 •
edited
Loading

Only export model directry, not export ormbfile.yaml, right？
I have a problem: the ormbfile.yaml's size is small, why not export, have any other reason？
@gaocegege

@gaocegege
Copy link
Member Author

Some servers will check the mode directory. If it finds that there is a new file, it may fail to serve.

@gaocegege
Copy link
Member Author

It is P2 I think, there is no need to do it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/P1 Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gaocegege @simon-cj