Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upcoming change to in_place will break generator.py #17

Open
jwodder opened this issue Oct 11, 2023 · 2 comments
Open

Upcoming change to in_place will break generator.py #17

jwodder opened this issue Oct 11, 2023 · 2 comments

Comments

@jwodder
Copy link

jwodder commented Oct 11, 2023

Hi, I'm the author of in_place, which this project uses in generator.py, and I'm letting you know that the upcoming v1.0 of in_place will bring API changes that will break your code; see this issue for more information.

Until v1.0 is released and your code is updated, I would suggest restricting the in_place version in your requirements.txt like so:

in_place < 1.0
@klezVirus
Copy link
Owner

THank you vey much @jwodder! I will follow your advice for now and update the code when version 1.0 is out ;)

@jwodder
Copy link
Author

jwodder commented Oct 12, 2023

I've just released in_place v1.0, but it turns out that I managed to find an alternative way to accomplish my goals without dropping support for the mode argument, so your code was safe all along. Sorry to bother you!

Side note: Despite my best efforts searching GitHub, this project is the only one I've found that uses mode="b". Do you feel special?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants