#421 contributing.md first draft #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LudwikJaniuk is attempting to deploy a commit to the Klimatbyrån Team on Vercel. A member of the Team first needs to authorize it. |
Greenheart
reviewed
May 2, 2024
Co-authored-by: Samuel Plumppu <6125097+Greenheart@users.noreply.github.com>
Co-authored-by: Samuel Plumppu <6125097+Greenheart@users.noreply.github.com>
Co-authored-by: Samuel Plumppu <6125097+Greenheart@users.noreply.github.com>
Co-authored-by: Samuel Plumppu <6125097+Greenheart@users.noreply.github.com>
Greenheart
approved these changes
May 2, 2024
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Greenheart
added a commit
that referenced
this pull request
May 6, 2024
…495) * Fix for raw HTML visible briefly on page load (#483) * Update site copy (#223) (#224) Copy changes, including cement deduction text * reintroduce climate plans * Add routing to climate plans * updated calculations and data * fix: hide climate plans before launch * fixes raw html flicker --------- * #421 contributing.md first draft (#489) First version of a contribution guide. * Ensure public assets served from the same domain are opened in a new tab (#490) * Improve layout for 404 page * Ensure public assets served from the same domain are opened in a new tab. This helps us only preload Next.js data for internal links leading to actual pages. * Use internal link to the same domain * Some overviews to help see the big picture in Readme (#492) * add en- and decoding to municipality routing (#493) * add en- and decoding to municipality routing as well as minor cleanup * Update __tests__/utils/generateMunipacitySitemap.test.ts * Update __tests__/utils/generateMunipacitySitemap.test.ts * Update __tests__/utils/generateMunipacitySitemap.test.ts * Update pages/sitemap.xml.ts * Update pages/sitemap.xml.ts * Update utils/generateMunipacitySitemap.ts --------- Co-authored-by: Samuel Plumppu <6125097+Greenheart@users.noreply.github.com> * rm default arrow from toggle section plus minor cleanup (#494) --------- Co-authored-by: Adebayo Ajayi <54339202+Braggedtooth@users.noreply.github.com> Co-authored-by: Ludvig Janiuk <ludvig.janiuk@gmail.com> Co-authored-by: Samuel Plumppu <6125097+Greenheart@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to describe how to make a PR as well as good "rules of engagement" or something along those lines. The intention is to balance several different needs from different roles, including volunteer's need for transparency and guidance, and core team's need for efficiency and control.
I appreciate feedback but preferably with limited bikeshedding ;)