Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/newsletter anchor link and styling #504

Merged
merged 3 commits into from
May 8, 2024

Conversation

Greenheart
Copy link
Collaborator

@Greenheart Greenheart commented May 7, 2024

Included changes:

  • Add anchor link to show the newsletter form directly
  • Add scroll-padding-top to the root html element to allow scrolling to anchor links and still accounting for the fixed header.
  • Improve newsletter form spacing and use consistent translation keys with namespace included

All pages that include the newsletter form will now support the anchor link #newsletter at the end of the URL. Thanks to the added scroll padding, this now gives a quite nice experience.

Screencast.from.2024-05-07.16-48-34.mp4

Copy link

vercel bot commented May 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
klimatkollen ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2024 2:57pm

@Greenheart Greenheart requested a review from elvbom May 7, 2024 17:07
Copy link
Collaborator

@elvbom elvbom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bra jobbat!

@elvbom elvbom merged commit afef026 into staging May 8, 2024
2 checks passed
@Greenheart Greenheart deleted the feature/newsletter-anchor-link-and-styling branch May 8, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants