Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes, lower thresholds for consumption emissions and enhanced newletter form #506

Merged
merged 12 commits into from
May 10, 2024

Conversation

elvbom
Copy link
Collaborator

@elvbom elvbom commented May 8, 2024

Includes:

  • Remove duplicate i18n config
  • Lower thresholds for consumption related emissions
  • WAI-ARIA adapt newletter form
  • Remove duplicate requirements.txt
  • Newsletter anchor link and styling

Braggedtooth and others added 11 commits April 30, 2024 16:42
* Update site copy (#223) (#224)

Copy changes, including cement deduction text

* reintroduce climate plans

* Add routing to climate plans

* updated calculations and data

* fix: hide climate plans before launch

* fixes raw html flicker

---------
First version of a contribution guide.
…tab (#490)

* Improve layout for 404 page

* Ensure public assets served from the same domain are opened in a new tab.

This helps us only preload Next.js data for internal links leading to actual pages.

* Use internal link to the same domain
* add en- and decoding to municipality routing as well as minor cleanup

* Update __tests__/utils/generateMunipacitySitemap.test.ts

* Update __tests__/utils/generateMunipacitySitemap.test.ts

* Update __tests__/utils/generateMunipacitySitemap.test.ts

* Update pages/sitemap.xml.ts

* Update pages/sitemap.xml.ts

* Update utils/generateMunipacitySitemap.ts

---------

Co-authored-by: Samuel Plumppu <6125097+Greenheart@users.noreply.github.com>
* lower thresholds for consumption related emissions

* update map labels
* Add anchor link to show the newsletter form

* Improve newsletter form spacing and use consistent translation keys with namespace included

* Add scroll-padding-top to the root html element to allow scrolling to anchor links and still accounting for the fixed header.
@elvbom elvbom requested a review from Greenheart May 8, 2024 08:40
Copy link

vercel bot commented May 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
klimatkollen ✅ Ready (Inspect) Visit Preview May 10, 2024 6:10am

Copy link
Collaborator

@Greenheart Greenheart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need the newsletter update with privacy policy etc before merging. Will fix that during the day.

Apart from that, this is ready to publish.

@elvbom
Copy link
Collaborator Author

elvbom commented May 10, 2024

We need the newsletter update with privacy policy etc before merging. Will fix that during the day.

Apart from that, this is ready to publish.

Status on this?

@elvbom
Copy link
Collaborator Author

elvbom commented May 10, 2024

Reviewed by me alone due to time constraints ahead of the release

@elvbom elvbom merged commit 10b71a3 into main May 10, 2024
3 checks passed
@Greenheart Greenheart deleted the fix/merge-conflict branch May 10, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants