Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add config clearDataOnError etc #319

Closed
klis87 opened this issue Mar 22, 2020 · 1 comment
Closed

add config clearDataOnError etc #319

klis87 opened this issue Mar 22, 2020 · 1 comment

Comments

@klis87
Copy link
Owner

klis87 commented Mar 22, 2020

I am not sure this is actually necessary, we have resetRequests action now. But if you think this might be useful, please provide use cases

@klis87
Copy link
Owner Author

klis87 commented May 20, 2020

I think this is redundant to implement:

  • on request data should not be cleared, as people could show old data when a new one is being fetched, if not a spinner could be shown
  • on success data is updated anyway
  • on error data should be cleared as error is set
  • on abort - this one is the most tricky, we dont clear data for this one, maybe we should or maybe it should be configurable, but I think this doesnt really matter, requests usually will be aborted due to new request fired with takeLatest: true or resetRequests action usually, so data will be updated anyway

@klis87 klis87 closed this as completed May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant