Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add public_url option #230

Merged
merged 4 commits into from
Dec 19, 2018
Merged

add public_url option #230

merged 4 commits into from
Dec 19, 2018

Conversation

albanm
Copy link
Contributor

@albanm albanm commented Oct 24, 2017

Hello,

I needed to expose the tileserver on a subdirectory behind a reverse proxy. The configuration in #56 was too hackish. So I added an option to explicitly give a public url to tileserver so that it doesn't try to make a guess using headers (still uses current policy when the option is not defined).

I suppose some other users might be interested.

I wrote Dockerfile_test simply to be able to run the unit tests without installing stuff on my OS. But it is not really related to the PR.

@sweco-semhul
Copy link

Any plans on getting this PR merged?
Looks like a solid fix to me and its something I strongly need.

@petrsloup
Copy link
Member

Could you please update this PR ? Most importantly nomnom was replaced with commander in #263

Could you also add a line to the usage documentation (https://github.com/klokantech/tileserver-gl/blob/master/docs/usage.rst) about this feature?

@albanm
Copy link
Contributor Author

albanm commented Jun 25, 2018

I will look into it, but I am pretty busy right now. Either an evening this week, or next friday.

@sweco-semhul
Copy link

Seeing some issues with sprites requests when using the public_url setting. Not able to see whats the real problem. But I'm guessing it could be related to fixUrl method for paths not specified with local:// but only with the server path.

@lamuertepeluda
Copy link

any news on this? I think it'd be a pretty useful feature...

@richturner
Copy link

This requirement has come up in several places and a PR was submitted in #86 but still this functionality isn't finding its way into the code base....here's another vote for this feature as it really is useful.

@richturner
Copy link

If you want to use this public_url functionality in a docker image I've created a Dockerfile that pulls the source files from this fork just build this image:

https://gist.github.com/richturner/25a63f250a4d1f2b1d9883a8e64a0705

@petrsloup
Copy link
Member

petrsloup commented Dec 19, 2018

Looking forward to merging this once it's cleaned up against the current master. Looks like a lot of people could benefit from this feature.

# Conflicts:
#	src/main.js
#	src/server.js
@albanm
Copy link
Contributor Author

albanm commented Dec 19, 2018

Sorry about that... I got lazy on this one.

Should be ok after the last commit.

@petrsloup petrsloup merged commit cde0233 into maptiler:master Dec 19, 2018
@petrsloup
Copy link
Member

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants