Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license to POD, fix pod and add test #2

Merged
merged 5 commits into from
Jan 23, 2017
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion MANIFEST
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@ t/make.t
t/00-compile.t
t/94-version.t
t/95-tidyall.t
t/96-perlcritic.t
t/96-perl-critic.t
t/97-pod.t
.perlcriticrc
.perltidyrc
.tidyallrc
5 changes: 3 additions & 2 deletions Makefile.PL
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,9 @@ my %config = (
);

my %test_requires = (
'Test::More' => 1,
'Test::Compile' => '1.2.1',
'Test::More' => 1,
'Test::Compile' => '1.2.1',
'Test::Pod' => '1.00'
);

if ( eval { ExtUtils::MakeMaker->VERSION(6.64) } ) {
Expand Down
7 changes: 7 additions & 0 deletions lib/Make.pm
Original file line number Diff line number Diff line change
Expand Up @@ -1161,6 +1161,13 @@ L<pmake>

Nick Ing-Simmons

=head1 COPYRIGHT AND LICENSE

Copyright (c) 1996-1999 Nick Ing-Simmons.

This program is free software; you can redistribute it and/or
modify it under the same terms as Perl itself.

=cut

1;
Expand Down
7 changes: 5 additions & 2 deletions pmake
Original file line number Diff line number Diff line change
Expand Up @@ -52,19 +52,22 @@ For details see L<Make> for the underlying perl module.

=head1 BUGS

=over

=item *

No B<-k> flag

I strongly suspect there are lots more.

=back

=head1 SEE ALSO

L<Make>, make(1)

=head1 AUTHOR

Nick Ing-Simmons
Nick Ing-Simmons

=cut

11 changes: 11 additions & 0 deletions t/97-pod.t
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
#!/usr/bin/env perl

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add use strict/use warnings here?

use Test::More;
eval "use Test::Pod 1.00";
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a ##no critic before the eval?

if ($@) {
plan skip_all => "Test::Pod 1.00 required for testing POD";
}

my @files = ('pmake','bmake', all_pod_files(('lib')));

all_pod_files_ok(@files);