Windows executable for Version 1.2.0 not compiling

[linqiaozhi]

Since @jspidlen contributed a Visual Studio solution in #23, I have been using it to compile a Windows binary that I attach to each release. With this Version 1.2.0 release, I am encountering errors related to the Annoy library...even though we have not made any changes to the Annoy library since the last release.

The first error is the file mman.h is not in the include path. That file is in src\winlibs, and when I add it to the Additional Include Paths, a whole new series of errors appear relating to other dependencies of Annoy. I have no experience with Visual Studio, so I am struggling to solve them...just wanted to reach out to @jspidlen or other Windows developers to see if you could figure out what changed.

[dkobak]

Oh this might be why the conda package complained about the Windows version!

Will @JosefFlowJo get notified or should we email him?

[JosefFlowJo]

Thanks Dmitry, My apologies, I don’t have the computer with the MS Visual Studio that I had back in 2018 for this, so I don’t think I will be able to help troubleshoot the Windows builds at this point. Josef From: Dmitry Kobak <notifications@github.com> Reply-To: KlugerLab/FIt-SNE <reply@reply.github.com> Date: Monday, March 30, 2020 at 2:26 AM To: KlugerLab/FIt-SNE <FIt-SNE@noreply.github.com> Cc: Josef Spidlen <Josef.Spidlen@bd.com>, Mention <mention@noreply.github.com> Subject: Re: [KlugerLab/FIt-SNE] Windows executable for Version 1.2.0 not compiling (#95) Oh this might be why the conda package complained about the Windows version! Will @JosefFlowJo<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_JosefFlowJo&d=DwMCaQ&c=wgu6hzw1MOrcVMSMqu8IcS59mhBvl1Fc7tKn_Em0PVg&r=oCo5t7Gmj0cCw24MJkN6dNxJNV-3_UdrZzyqY57uKro&m=W_tQ4sMwyhy28GUUUpGKOuG1ZfWJCB7LgA2FhBO5eSE&s=cQxpbjM8Fr9G6rtnKn74FBVoD5rspOKP9LQ2uZ90EdE&e=> get notified or should we email him? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_KlugerLab_FIt-2DSNE_issues_95-23issuecomment-2D605886641&d=DwMCaQ&c=wgu6hzw1MOrcVMSMqu8IcS59mhBvl1Fc7tKn_Em0PVg&r=oCo5t7Gmj0cCw24MJkN6dNxJNV-3_UdrZzyqY57uKro&m=W_tQ4sMwyhy28GUUUpGKOuG1ZfWJCB7LgA2FhBO5eSE&s=OSS0jaluvqRvv6At1s54f0-Kl5YVP33pfr96_lj9qdg&e=>, or unsubscribe<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AGNEKOY4CQKT2VMT5BDM2CLRKBQT3ANCNFSM4LWHBYGA&d=DwMCaQ&c=wgu6hzw1MOrcVMSMqu8IcS59mhBvl1Fc7tKn_Em0PVg&r=oCo5t7Gmj0cCw24MJkN6dNxJNV-3_UdrZzyqY57uKro&m=W_tQ4sMwyhy28GUUUpGKOuG1ZfWJCB7LgA2FhBO5eSE&s=z5L53ePwLGJ2Zw0bXwQVWnpYbzsraK5Xc9bgPpze9jY&e=>. ******************************************************************* IMPORTANT MESSAGE FOR RECIPIENTS IN THE U.S.A.: This message may constitute an advertisement of a BD group's products or services or a solicitation of interest in them. If this is such a message and you would like to opt out of receiving future advertisements or solicitations from this BD group, please forward this e-mail to optoutbygroup@bd.com. [BD.v1.0] ******************************************************************* This message (which includes any attachments) is intended only for the designated recipient(s). It may contain confidential or proprietary information and may be subject to the attorney-client privilege or other confidentiality protections. If you are not a designated recipient, you may not review, use, copy or distribute this message. If you received this in error, please notify the sender by reply e-mail and delete this message. Thank you. ******************************************************************* Corporate Headquarters Mailing Address: BD (Becton, Dickinson and Company) 1 Becton Drive Franklin Lakes, NJ 07417 U.S.A.

[dkobak]

@linqiaozhi We did update the Annoy version though, around four months ago: 42e4617. I wonder if the errors are connected to that.

The first error is the file mman.h is not in the include path. That file is in src\winlibs, and when I add it to the Additional Include Paths, a whole new series of errors appear relating to other dependencies of Annoy.

I would guess that src\winlibs should be in the include path (didn't you need it there previously?). Can you post the errors you are getting?

[dkobak]

Hmm, we might need to update the mman.h file, taking it from here: https://github.com/spotify/annoy/tree/master/src

[linqiaozhi]

Resolved!