Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix README.md instructions and raise errors when LMP market not supported #13

Merged
merged 7 commits into from
Aug 13, 2022

Conversation

gsheni
Copy link
Contributor

@gsheni gsheni commented Aug 13, 2022

  • Noticed some errors in the README (while copying and pasting codeblocks)
  • Raise errors when LMP market not supported

@gsheni
Copy link
Contributor Author

gsheni commented Aug 13, 2022

  • One weird error I get locally (Mac) but not on the GitHub CI (Ubuntu) is the following:
        date_str = "20220722"
        for m in markets:
            print(iso.iso_id, m)
            latest = iso.get_latest_lmp(m, nodes=nodes)
>           assert isinstance(latest, pd.DataFrame)

isodata/tests/test_isos.py:251:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
isodata/miso.py:102: in get_latest_lmp
    time = pd.to_datetime(time_str).tz_localize(self.default_timezone)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

>   ???
E   TypeError: Cannot localize tz-aware Timestamp, use tz_convert for conversions

pandas/_libs/tslibs/timestamps.pyx:1849: TypeError
  • Not sure if others are also running into this error. My guess is that GitHub machine is in a different timezone than my local computer

@kmax12
Copy link
Collaborator

kmax12 commented Aug 13, 2022

the timezone error is interesting. filled a separate issue to take a look, but we can merge this is since it's unrelated

@kmax12 kmax12 merged commit abe4fd5 into gridstatus:main Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants