Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

download: broken at Yukicoder No.750,751 #192

Closed
kmyk opened this issue Nov 9, 2018 · 7 comments
Closed

download: broken at Yukicoder No.750,751 #192

kmyk opened this issue Nov 9, 2018 · 7 comments

Comments

@kmyk
Copy link
Member

kmyk commented Nov 9, 2018

https://yukicoder.me/problems/no/750
https://yukicoder.me/problems/no/751

@kawacchu
Copy link
Contributor

https://yukicoder.me/problems/no/750
https://yukicoder.me/problems/no/751

I checked the HTML source.
In no.750 and no.751, I found that the <br> tag was written within the <pre> tag.

Ex) no.750 サンプル1
<pre>6<br />1 1<br />7 4<br />0 5<br />1 3<br />-8 9<br />5 1</pre>

I guess that is the cause of the bug.

@kmyk
Copy link
Member Author

kmyk commented Oct 12, 2019

@kawacchu If you're interested in, please make the pull request!

@kawacchu
Copy link
Contributor

@kmyk @fukatani

Although I'm a beginner in this field, I will do my best!
When I'm in trouble, I ask for your advice!

@kawacchu
Copy link
Contributor

kawacchu commented Oct 15, 2019

I am going to prepare my pull request!
Which branch is preferable, master or develop?

My pull request will solve this issue, but the unexpected behavior for the user will remain in some problems. (although I have never seen it in a real environment.)

@fukatani
Copy link
Contributor

Please create branch from master. I removed develop branch.

My pull request will solve this issue, but the unexpected behavior for the user will remain in some problems. (although I have never seen it in a real environment.)

Unittest and code review reduce such a risk, let's do our best together!

@kawacchu
Copy link
Contributor

OK, thanks!

@kmyk
Copy link
Member Author

kmyk commented Oct 15, 2019

This issue is fixed by #552, and the remaining problem is opened as #553.
Thank you, @kawacchu.

@kmyk kmyk closed this as completed Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants