Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcd provider does not support this method #210

Closed
lyonnee opened this issue Apr 7, 2023 · 3 comments
Closed

etcd provider does not support this method #210

lyonnee opened this issue Apr 7, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@lyonnee
Copy link

lyonnee commented Apr 7, 2023

Describe the bug
When I use etcd as provider, I get this error message

To Reproduce
image

Expected behavior
Can parse my configuration information from etcd

Please provide the following information):

  • OS: osx
  • Koanf Version v2.0.0
  • providers/etcd Version v0.1.1
@lyonnee lyonnee added the bug Something isn't working label Apr 7, 2023
@jxsl13
Copy link
Contributor

jxsl13 commented Apr 7, 2023

nil checking the returned object is pretty bad imo. The Provider function should return a second error value.

This will lead to defensive programming where you start to distrust returned pointer values.

It would be great if you could provide a way to setup a test environment quickly.

@lyonnee
Copy link
Author

lyonnee commented Apr 10, 2023

@jxsl13
I fully agree with your opinion that judging whether Provider is equal to nil is a very bad approach. I am planning to modify the source code here to initiate PR

@knadh knadh added enhancement New feature or request and removed bug Something isn't working labels Apr 18, 2023
@lyonnee
Copy link
Author

lyonnee commented May 4, 2023

The new PR is here #217

@lyonnee lyonnee closed this as not planned Won't fix, can't repro, duplicate, stale May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants