Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhc: add plain text email body along with HTML increasing deliverability #80

Merged
merged 1 commit into from
Apr 14, 2020

Conversation

jaredfolkins
Copy link
Contributor

I saw issue #79 and as I need this functionality, I figured I'd offer a PR.

Thanks,
Jared

@knadh
Copy link
Owner

knadh commented Apr 10, 2020

Excellent! I think we should make this optional though. A plaintext_email = true option in the config would be perfect for now. In the future, it can be a per-campaign option as well.

@jaredfolkins
Copy link
Contributor Author

Actually, would you consider, email_format = {plain|html|both}?

@jaredfolkins
Copy link
Contributor Author

In the future, it can be a per-campaign option as well.

Hehe. I actually started here. I have a lot of the code done but then I realized that functions like Push() would most likely need their signatures changed substantially.

@knadh
Copy link
Owner

knadh commented Apr 10, 2020

email_format = {plain|html|both} is the ideal scenario.

Push() is a bit ugly. It has too many params and should've been refactored earlier. We can introduce a messenger.Message struct and have Push() just take that.

@jaredfolkins
Copy link
Contributor Author

Please review. Thanks!

@knadh
Copy link
Owner

knadh commented Apr 14, 2020

Cheers. Will push a release soon with a few other things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants