Default value for KafkaActivationLagThreshold throws error

[aavarghese]

Issue: When using current default value in this repo for KedaAutoscalingKafkaActivationLagThreshold, it throws an error:

error parsing kafka metadata: "activationLagThreshold" must be positive number

Reason: KEDA has a validation check for ActivationLagThreshold
https://github.com/kedacore/keda/blob/03b35d2fbac00c6d921b218519da865861db6456/pkg/scalers/kafka_scaler.go#L232-L243 that fails when value is 0.

Solution: Default for ActivationLagThreshold must be changed to a positive number or validation logic modified. What is the allowed range for this scaling annotation?

cc: @zroubalik @pierDipi

[pierDipi]

I think it makes sense to be a positive number only because it is specifying how many records there should be to scale from 0 to 1, since this is a default value, I think 1 is a good default so that we start consuming as soon as there is at least one record

[aavarghese]

Agreed! @pierDipi

[github-actions]

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

[pierDipi]

/remove-lifecycle stale
/triage accepted