New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The errors in `update-codegen.sh` are silenced #342

Open

cardil opened this issue Oct 12, 2023 · 0 comments

Labels

kind/bug

Contributor

cardil commented Oct 12, 2023

knobots/actions/update-deps/entrypoint.sh

Line 65 in f15f57f

[[ ! -f hack/update-codegen.sh ]] || ./hack/update-codegen.sh

This line is probably buggy. In shell, if the whole line will be evaluated as conditional, and conditionals doesn't fail the script.

It most likely should be:

if [[ ! -f hack/update-codegen.sh ]]; then
  ./hack/update-codegen.sh
fi

/kind bug

knative-prow bot added the kind/bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment