fix: make registry validation work again

[lance]

Changes

In ccf0015
the behavior of NewFunction() changed slightly, such that it no longer actually
works without a provided and valid path. This was not caught in any of the
tests, because it's the CLI code that was making this call, and the end to end
tests that exercise the build command, use the --registry flag, causing
the repository validation code path to be slightly different.

🧹 This commit just adds the path so that func build without a --registry flag will work again.

EDIT: Converting to a draft, because really, any registry should be validated even if it's provided as a CLI flag. I will add that validation and a test.

/kind fix

[knative-prow-robot]

@lance: The label(s) kind/fix cannot be applied, because the repository doesn't have them.

In response to this:

Changes

In ccf0015
the behavior of NewFunction() changed slightly, such that it no longer actually
works without a provided and valid path. This was not caught in any of the
tests, because it's the CLI code that was making this call, and the end to end
tests that exercise the build command, use the --repository flag, causing
the repository validation code path to be slightly different.

🧹 This commit just adds the path so that func build without a --repository flag will work again.

/kind fix

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

Merging #690 (2bba8c8) into main (4b3a5c3) will increase coverage by 0.80%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##             main     #690      +/-   ##
==========================================
+ Coverage   38.15%   38.95%   +0.80%     
==========================================
  Files          42       42              
  Lines        3916     3920       +4     
==========================================
+ Hits         1494     1527      +33     
+ Misses       2219     2181      -38     
- Partials      203      212       +9     

Impacted Files	Coverage Δ
cmd/build.go	45.13% <85.71%> (+17.60%)	⬆️
cmd/root.go	58.49% <0.00%> (+11.32%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b3a5c3...2bba8c8. Read the comment docs.

[lkingland]

Thanks for the fix!

/lgtm

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance, lkingland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [lance,lkingland]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment