-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make registry validation work again #690
Conversation
In knative@ccf0015 the behavior of `NewFunction()` changed slightly, such that it no longer actually works without a provided and valid path. This was not caught in any of the tests, because it's the CLI code that was making this call, and the end to end tests that exercise the build command, use the `--repository` flag, causing the repository validation code path to be slightly different. This commit just adds the path so that `func build` without a `--repository` flag will work again. Signed-off-by: Lance Ball <lball@redhat.com>
@lance: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## main #690 +/- ##
==========================================
+ Coverage 38.15% 38.95% +0.80%
==========================================
Files 42 42
Lines 3916 3920 +4
==========================================
+ Hits 1494 1527 +33
+ Misses 2219 2181 -38
- Partials 203 212 +9
Continue to review full report at Codecov.
|
Signed-off-by: Lance Ball <lball@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance, lkingland The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
In ccf0015
the behavior of
NewFunction()
changed slightly, such that it no longer actuallyworks without a provided and valid path. This was not caught in any of the
tests, because it's the CLI code that was making this call, and the end to end
tests that exercise the build command, use the
--registry
flag, causingthe repository validation code path to be slightly different.
🧹 This commit just adds the path so that
func build
without a--registry
flag will work again.EDIT: Converting to a draft, because really, any registry should be validated even if it's provided as a CLI flag. I will add that validation and a test.
/kind fix