Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump patches #699

Merged
merged 2 commits into from
Jul 8, 2021
Merged

Conversation

dprotaso
Copy link
Contributor

@dprotaso dprotaso commented Jul 5, 2021

  • bump stable to 1.9.6
  • bump latest patch to 1.10.2

@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 5, 2021
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 5, 2021
@codecov
Copy link

codecov bot commented Jul 5, 2021

Codecov Report

Merging #699 (4d2d57c) into main (b6e232f) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #699      +/-   ##
==========================================
- Coverage   80.52%   80.45%   -0.08%     
==========================================
  Files          18       18              
  Lines        1104     1110       +6     
==========================================
+ Hits          889      893       +4     
- Misses        133      134       +1     
- Partials       82       83       +1     
Impacted Files Coverage Δ
pkg/reconciler/ingress/resources/gateway.go 86.11% <0.00%> (-1.04%) ⬇️
pkg/reconciler/ingress/ingress.go 71.18% <0.00%> (+0.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3afd151...4d2d57c. Read the comment docs.

@dprotaso
Copy link
Contributor Author

dprotaso commented Jul 5, 2021

These patches fix the gateway port mapping conflict. Note these need to be paired with @howardjohn's PR #636

/assign @nak3

cc @julz @arturenault who reviewed the prior PR

@knative-prow-robot
Copy link
Contributor

@howardjohn: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@nak3 nak3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, howardjohn, nak3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit f30c042 into knative-extensions:main Jul 8, 2021
@dprotaso dprotaso deleted the bump-patches branch July 8, 2021 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants