Skip to content
This repository has been archived by the owner on Sep 5, 2019. It is now read-only.

Show intermediate update of build steps #309

Merged
merged 1 commit into from Aug 23, 2018

Conversation

shashwathi
Copy link
Contributor

Fixes #304

Proposed Changes

  • Intermediate build steps like waiting, running.

@shashwathi
Copy link
Contributor Author

/assign @imjasonh

@knative-metrics-robot
Copy link

The following is the coverage report on pkg/.
Say /test pull-knative-build-go-coverage to run the coverage report again

File Old Coverage New Coverage Delta
pkg/builder/cluster/builder.go 80.7% 81.3% 0.6

apiVersion: build.knative.dev/v1alpha1
kind: Build
metadata:
name: test-build-with-more-steps
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a few tests that happen to specify multiple steps, e.g., test-custom-volume and test-home-volume.

It's a real limitation of our integration testing "framework" that the only way we have right now to test things against a real cluster is to send builds and expect them to succeed or fail. Once we have a more "real" framework in place (stolen from knative/serving no doubt), we can have a test that runs a multi-step build and watches to see multiple status updates.

Until then, I'm not sure this test really adds much, except that it's proof that a build that has two steps succeeds.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I completely agree with you on this.

@imjasonh
Copy link
Member

The rest of this change looks great though, and I can't wait to get updates about the build's status while it's ongoing.

/lgtm
/approve
🎉

@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ImJasonH, shashwathi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit fca74b9 into knative:master Aug 23, 2018
@shashwathi shashwathi deleted the intermediate-update branch October 9, 2018 18:52
vdemeester pushed a commit to vdemeester/knative-build that referenced this pull request Apr 3, 2019
vdemeester pushed a commit to vdemeester/knative-build that referenced this pull request Apr 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants