This repository has been archived by the owner on Sep 5, 2019. It is now read-only.
Vendor knative/caching and start instantiating them for sidecars. #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imjasonh
reviewed
Sep 13, 2018
|
Nope. /lgtm |
|
The test failure looks realish. I'll TAL after lunch. |
mattmoor
force-pushed
the
image-resources
branch
from
9b58a3a
to
3f0a523
Compare
mattmoor
force-pushed
the
image-resources
branch
from
3f0a523
to
e1e1a77
Compare
|
Ok, so it looks like waiting for the |
This also plumbs through the lister/informer for the template reconcilers.
mattmoor
force-pushed
the
image-resources
branch
from
e1e1a77
to
0cb3f8c
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ImJasonH, mattmoor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
vdemeester
pushed a commit
to vdemeester/knative-build
that referenced
this pull request
Apr 3, 2019
…ative#348) This also plumbs through the lister/informer for the template reconcilers.
vdemeester
pushed a commit
to vdemeester/knative-build
that referenced
this pull request
Apr 3, 2019
…ative#348) This also plumbs through the lister/informer for the template reconcilers.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also plumbs through the lister/informer for the template reconcilers.