Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed hard-coded "kn" in usage/error messages #1191

Closed
rhuss opened this issue Jan 14, 2021 · 12 comments · Fixed by #1603
Closed

Removed hard-coded "kn" in usage/error messages #1191

rhuss opened this issue Jan 14, 2021 · 12 comments · Fixed by #1603
Assignees
Labels
good first issue Denotes an issue ready for a new contributor. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature New feature or request triage/accepted Issues which should be fixed (post-triage)
Milestone

Comments

@rhuss
Copy link
Contributor

rhuss commented Jan 14, 2021

Instead use argv[0], the first argument provided on the command line. If the command is called with a path, that path should be stripped off from the given argument.

See #1175 for more context.

@rhuss rhuss added the kind/feature New feature or request label Jan 14, 2021
@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 15, 2021
@rhuss
Copy link
Contributor Author

rhuss commented Apr 15, 2021

/good-first-issue
/remove-lifecycle stale

@knative-prow-robot
Copy link
Contributor

@rhuss:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue
/remove-lifecycle stale

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added good first issue help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 15, 2021
@rhuss rhuss added the triage/accepted Issues which should be fixed (post-triage) label Jul 6, 2021
@rhuss rhuss added good first issue Denotes an issue ready for a new contributor. and removed good first issue labels Jul 9, 2021
@hzliangbin
Copy link

/assign

@hzliangbin
Copy link

@rhuss hi, plz let me know if I could take this issue? thanks.

@rhuss
Copy link
Contributor Author

rhuss commented Sep 27, 2021

@hzliangbin That's great ! Please go ahead and take this issue.

@hzliangbin
Copy link

@rhuss sorry for being late.
kn
kn in root cmd usage and help should be modified too?

@rhuss
Copy link
Contributor Author

rhuss commented Dec 2, 2021

no worries.

@hzliangbin yes, ideally everywhere where kn is hardcoded, that should be replaced by the real command name, without path.

@rhuss
Copy link
Contributor Author

rhuss commented Jan 4, 2022

@hzliangbin happy new year ;-) Do you have any news on this issue ? No worries if you hadn't any time yet, but we want to tackle this story possibly for the next release.

@hzliangbin
Copy link

hzliangbin commented Jan 7, 2022

@rhuss sorry. haven't got any new ideas.

@rhuss
Copy link
Contributor Author

rhuss commented Jan 18, 2022

No worries. If you don't mind, I would unassign you from this issue and add you as a reviewer when a PR comes in ?

@rhuss rhuss added this to the v0.28 milestone Jan 18, 2022
@rhuss rhuss modified the milestones: 1.2 (0.28), 1.3 (0.29) Jan 25, 2022
@itsmurugappan
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature New feature or request triage/accepted Issues which should be fixed (post-triage)
Projects
Status: Done
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants