Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a message on stdout after service create #87

Closed
navidshaikh opened this issue May 3, 2019 · 1 comment · Fixed by #95
Closed

Add a message on stdout after service create #87

navidshaikh opened this issue May 3, 2019 · 1 comment · Fixed by #95

Comments

@navidshaikh
Copy link
Collaborator

kn service create returns without any hint, lets add a message about service creation status.
For eg:
Created <SERVICE_NAME> in namespace.
@maximilien
Copy link
Contributor

I can do this too if you are not addressing. LMK.

navidshaikh added a commit to navidshaikh/client that referenced this issue May 8, 2019
@navidshaikh
Adds info message after service create operation
86f61a0 
 Fixes knative#87
@navidshaikh navidshaikh mentioned this issue May 8, 2019
Merged
navidshaikh added a commit to navidshaikh/client that referenced this issue May 9, 2019
@navidshaikh
Adds info message after service create operation
7f3f80c 
 Fixes knative#87
navidshaikh added a commit to navidshaikh/client that referenced this issue May 10, 2019
@navidshaikh
Adds info message after service create operation
cf56084 
 Fixes knative#87

 Aligns the service delete info message with service create too.
knative-prow-robot pushed a commit that referenced this issue May 14, 2019
@navidshaikh @knative-prow-robot
Adds info message after service create and delete operations (#95)
5b8b9d5 
* Adds info message after service create operation

 Fixes #87

 Aligns the service delete info message with service create too.

* Updates per review comments

 Adds newline after std imports
 Line breaks at proper operator
maximilien pushed a commit to maximilien/client that referenced this issue May 14, 2019
@navidshaikh @maximilien
Adds info message after service create and delete operations (knative#95
6d7573f 
)

* Adds info message after service create operation

 Fixes knative#87

 Aligns the service delete info message with service create too.

* Updates per review comments

 Adds newline after std imports
 Line breaks at proper operator
maximilien pushed a commit to maximilien/client that referenced this issue May 14, 2019
@navidshaikh @maximilien
Adds info message after service create and delete operations (knative#95
7332ec5 
)

* Adds info message after service create operation

 Fixes knative#87

 Aligns the service delete info message with service create too.

* Updates per review comments

 Adds newline after std imports
 Line breaks at proper operator
maximilien pushed a commit to maximilien/client that referenced this issue May 14, 2019
@navidshaikh @maximilien
Adds info message after service create and delete operations (knative#95
a3e9925 
)

* Adds info message after service create operation

 Fixes knative#87

 Aligns the service delete info message with service create too.

* Updates per review comments

 Adds newline after std imports
 Line breaks at proper operator
coryrc pushed a commit to coryrc/client that referenced this issue May 14, 2020
@adrcunha
Properly fix acquire_cluster_admin_role() (knative#87)
4a4a682 
`kubectl` 1.11 doesn't recognize the `--username` and `--password` flags anymore. Because the `prow-tests` image uses `kubectl` 1.8, the Prow jobs are not broken (yet).

The changes in knative#86 don't work because the context is not changed (nor restored), but the function works as long as the current user is an owner of the GCP project (which is not the case for Prow E2E test jobs).

This change creates and uses a new context for the cluster admin, created the role binding, then switches back to the original context. This is more secure as no ACL changes are required for the current user, nor project wide ACL changes are performed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds info message after service create and delete operations navidshaikh/client
2 participants
@maximilien @navidshaikh