Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds service delete command #63

Merged
merged 2 commits into from
Apr 11, 2019
Merged

Adds service delete command #63

merged 2 commits into from
Apr 11, 2019

Conversation

navidshaikh
Copy link
Collaborator

@navidshaikh navidshaikh commented Apr 5, 2019 •
edited
Loading

This chageset adds service delete command, able to delete a service
at a time.

Fixes #49

kn service delete --help
Delete a service

Usage:
  kn service delete <SERVICE_NAME> [flags]

Aliases:
  delete, del, d

Examples:

  # Delete a service 'svc1' in default namespace
  kn service delete svc1

  # Delete a service 'svc2' in 'ns1' namespace
  kn service delete svc2 -n ns1

@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 5, 2019
@navidshaikh
Adds service delete command
8c57ed0 
 This chageset adds `service delete` command, able to delete a service
 at a time.

 Fixes knative#49

```
kn service delete --help
Delete a service

Usage:
  kn service delete <SERVICE_NAME> [flags]

Aliases:
  delete, del, d

Examples:

  # Delete a service 'svc1' in default namespace
  kn service delete svc1

  # Delete a service 'svc2' in 'ns1' namespace
  kn service delete svc2 -n ns1
```
@navidshaikh
Removes aliases, PreRunE and addresses review comments
0972ecb
@navidshaikh navidshaikh force-pushed the fix-49 branch 2 times, most recently from b937433 to 0972ecb Compare April 9, 2019 10:58
@navidshaikh
Copy link
Collaborator Author

/retest

@knative-prow-robot
Copy link
Contributor

@navidshaikh: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cppforlife
Copy link

/ok-to-test

@knative-prow-robot knative-prow-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 10, 2019
@knative-metrics-robot
Copy link

The following is the coverage report on pkg/.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/kn/commands/service_delete.go Do not exist 15.4%

@cppforlife
Copy link

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cppforlife, navidshaikh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2019
@knative-prow-robot knative-prow-robot merged commit 9c21b8d into knative:master Apr 11, 2019
navidshaikh added a commit to navidshaikh/client that referenced this pull request Apr 15, 2019
@navidshaikh
Adds service delete command (knative#63)
d4e2556 
* Adds service delete command

 This chageset adds `service delete` command, able to delete a service
 at a time.

 Fixes knative#49

```
kn service delete --help
Delete a service

Usage:
  kn service delete <SERVICE_NAME> [flags]

Aliases:
  delete, del, d

Examples:

  # Delete a service 'svc1' in default namespace
  kn service delete svc1

  # Delete a service 'svc2' in 'ns1' namespace
  kn service delete svc2 -n ns1
```

* Removes aliases, PreRunE and addresses review comments
navidshaikh added a commit to navidshaikh/client that referenced this pull request Apr 15, 2019
@navidshaikh
Adds service delete command (knative#63)
b4c7da4 
* Adds service delete command

 This chageset adds `service delete` command, able to delete a service
 at a time.

 Fixes knative#49

```
kn service delete --help
Delete a service

Usage:
  kn service delete <SERVICE_NAME> [flags]

Aliases:
  delete, del, d

Examples:

  # Delete a service 'svc1' in default namespace
  kn service delete svc1

  # Delete a service 'svc2' in 'ns1' namespace
  kn service delete svc2 -n ns1
```

* Removes aliases, PreRunE and addresses review comments
navidshaikh added a commit to navidshaikh/client that referenced this pull request Apr 15, 2019
@navidshaikh
Adds service delete command (knative#63)
d5a4c9d 
* Adds service delete command

 This chageset adds `service delete` command, able to delete a service
 at a time.

 Fixes knative#49

```
kn service delete --help
Delete a service

Usage:
  kn service delete <SERVICE_NAME> [flags]

Aliases:
  delete, del, d

Examples:

  # Delete a service 'svc1' in default namespace
  kn service delete svc1

  # Delete a service 'svc2' in 'ns1' namespace
  kn service delete svc2 -n ns1
```

* Removes aliases, PreRunE and addresses review comments
rhuss pushed a commit to rhuss/knative-client that referenced this pull request Apr 24, 2019
@navidshaikh @rhuss
Adds service delete command (knative#63)
c7ba300 
* Adds service delete command

 This chageset adds `service delete` command, able to delete a service
 at a time.

 Fixes knative#49

```
kn service delete --help
Delete a service

Usage:
  kn service delete <SERVICE_NAME> [flags]

Aliases:
  delete, del, d

Examples:

  # Delete a service 'svc1' in default namespace
  kn service delete svc1

  # Delete a service 'svc2' in 'ns1' namespace
  kn service delete svc2 -n ns1
```

* Removes aliases, PreRunE and addresses review comments
@navidshaikh navidshaikh mentioned this pull request Apr 26, 2019
Closed
6 tasks
@navidshaikh navidshaikh deleted the fix-49 branch November 18, 2019 12:38
coryrc pushed a commit to coryrc/client that referenced this pull request May 14, 2020
@adrcunha @knative-prow-robot
Use default GKE version for test cluster (knative#63)
2f17ed7 
`gke-latest` points to head, and these images might not yet be available for platforms other than Linux (e.g., Mac).

Fixes knative#40.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cppforlife cppforlife cppforlife left review comments

@evankanderson evankanderson Awaiting requested review from evankanderson

@mattmoor mattmoor Awaiting requested review from mattmoor

Assignees

@cppforlife cppforlife

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

service delete
4 participants
@navidshaikh @knative-prow-robot @cppforlife @knative-metrics-robot