Adds basic workflow #99

maximilien · 2019-05-09T21:36:50Z

deploy a function (list, update, curl, describe, and delete)

Completes more of issue #51

sixolet · 2019-05-09T22:08:16Z

/retest

sixolet

Moslty nits

sixolet · 2019-05-09T22:11:06Z

docs/workflows.md

+In this basic worflow we show the CRUD (create, read, update, delete) operations on a service. We use a well known [simple Hello World service](https://github.com/knative/docs/tree/master/docs/serving/samples/hello-world/helloworld-go) that reads the environment variable `TARGET` and prints it as output.
+
+1. Create a service from image in `default` namespace


Your markdown renders the numbered list as 1. 1. 1, rather than numbering properly.

Yeah, was afraid of that. I'll use bullet points. Thx.

sixolet · 2019-05-09T22:11:24Z

docs/workflows.md

+## Basic (get your feet wet)
+
+In this basic worflow we show the CRUD (create, read, update, delete) operations on a service. We use a well known [simple Hello World service](https://github.com/knative/docs/tree/master/docs/serving/samples/hello-world/helloworld-go) that reads the environment variable `TARGET` and prints it as output.


sixolet · 2019-05-09T22:11:35Z

docs/workflows.md

+The purpose of this section of the Kn documentation is to list what we believe are common workflows or use-cases for the Knative CLI. Obviously, as we release the CLI in the wild and get users in production, we might discover novel workflows. As we do we will improve this document.
+
+## Basic (get your feet wet)


s/Basic/Introductory/

sixolet · 2019-05-09T22:11:49Z

docs/workflows.md

+# Workflows
+
+The purpose of this section of the Kn documentation is to list what we believe are common workflows or use-cases for the Knative CLI. Obviously, as we release the CLI in the wild and get users in production, we might discover novel workflows. As we do we will improve this document.


s/what we believe are//

sixolet · 2019-05-09T22:12:42Z

docs/workflows.md

+# Workflows
+
+The purpose of this section of the Kn documentation is to list what we believe are common workflows or use-cases for the Knative CLI. Obviously, as we release the CLI in the wild and get users in production, we might discover novel workflows. As we do we will improve this document.


s/Obviously....end of paragraph/This is a live document, meant to be updated as we learn more about good ways to use kn/

More concise. I like it. Thx

rhuss · 2019-05-10T13:57:31Z

docs/workflows.md

+
+```bash
+$ kn service list


I think we agreed that this will be knative service get (same semantics as in kubectl)

OK let me see if in latest code I can do this. Otherwise, I'll omit until ready.

@rhuss the service get issue #48 is implemented in #90 but seems that it's on hold waiting on feedback and perhaps some code changes.

I added a comment to include a section for * Get service when that's ready.

rhuss · 2019-05-10T13:59:08Z

docs/workflows.md

+```bash
+$ kn service describe hello
+apiVersion: knative.dev/v1alpha1


The output of kn service describe will be always human readable, not yaml. Its kn service get hello -o yaml which returns a machine readable representation (with the same -o support as for kubectl as this is reused from Kubernete's cli-runtime).

I'd agree with that. However, current implementation yielded YAML. I simply cut and pasted and edited to redact.

I'll try with latest code and if not ready I'll remove (for now).

@rhuss no issue on this. Want to open it so we can see any feedback and I can address both.

rhuss · 2019-05-10T14:01:37Z

docs/workflows.md

+```bash
+$ kn service delete hello3
+$ Deleted hello3 in default namespace.


Sorry for nit-picking on high-level (pardonnez moi), but I would use here as a response:

Service 'hello3' in namespace 'default' deleted

(i.e. to make clear what is used provided data and mentioning early that's about a service)

I like that. I'll submit a PR. Again output is as is in current code.

rhuss · 2019-05-10T14:01:47Z

docs/workflows.md

+```
+
+You can then issue the same `$ kn service list` command to verify that the service was deleted.


kn service get

cppforlife · 2019-05-10T18:41:24Z

docs/workflows.md

+
+```bash
+curl '-sS' '-H' 'Host: hello.default.example.com' 'http://xxx.xx.xxx.xx:80'


let's remove :80 from here.

OK, fair enough.

cppforlife · 2019-05-10T18:41:29Z

docs/workflows.md

+```
+
+Where `http://xxx.xx.xxx.xx:80` is your Knative installation ingress.


cppforlife · 2019-05-10T18:42:15Z

i think it may also be useful to include output for all the commands ran.

maximilien · 2019-05-10T19:53:14Z

i think it may also be useful to include output for all the commands ran.

That's what I did. Some have no output (like service create) but that will change. There is an issue on that.

cppforlife · 2019-05-14T18:04:35Z

/lgtm
/approve

service get will be added when it's merged.

knative-prow-robot · 2019-05-14T18:04:46Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cppforlife, maximilien

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [cppforlife]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* Update spec file to release 1.6 * Cherry-pick test fixes, bump to client v1.6.1 --------- Co-authored-by: David Simansky <dsimansk@redhat.com>

knative-prow-robot requested review from cppforlife and evankanderson May 9, 2019 21:37

knative-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 9, 2019

sixolet reviewed May 9, 2019

View reviewed changes

rhuss reviewed May 10, 2019

View reviewed changes

cppforlife reviewed May 10, 2019

View reviewed changes

docs/workflows.md Outdated

```

Where `http://xxx.xx.xxx.xx:80` is your Knative installation ingress.

Copy link

cppforlife May 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and here

addressing comments on PR knative#99

cabcfa0

maximilien force-pushed the patch-1 branch from 1679228 to cabcfa0 Compare May 10, 2019 21:24

knative-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 10, 2019

maximilien mentioned this pull request May 13, 2019

Add integration tests to match the Basic workflow #104

Closed

knative-prow-robot assigned cppforlife May 14, 2019

knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2019

knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2019

knative-prow-robot merged commit 5703254 into knative:master May 14, 2019

maximilien added a commit to maximilien/client that referenced this pull request May 14, 2019

addressing comments on PR knative#99 (knative#99)

0aab351

maximilien added a commit to maximilien/client that referenced this pull request May 14, 2019

addressing comments on PR knative#99 (knative#99)

d3e0965

maximilien added a commit to maximilien/client that referenced this pull request May 14, 2019

addressing comments on PR knative#99 (knative#99)

b75700d

maximilien deleted the patch-1 branch May 14, 2019 19:31

coryrc pushed a commit to coryrc/client that referenced this pull request May 14, 2020

Remove stray slash from list of GKE versions (knative#99)

1665dee

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds basic workflow #99

Adds basic workflow #99

maximilien commented May 9, 2019

sixolet commented May 9, 2019

sixolet left a comment

sixolet May 9, 2019

maximilien May 10, 2019

sixolet May 9, 2019

sixolet May 9, 2019

maximilien May 10, 2019

sixolet May 9, 2019

maximilien May 10, 2019

sixolet May 9, 2019

maximilien May 10, 2019

rhuss May 10, 2019

maximilien May 10, 2019

maximilien May 10, 2019 •

edited

rhuss May 10, 2019

maximilien May 10, 2019

maximilien May 10, 2019

rhuss May 10, 2019

maximilien May 10, 2019

rhuss May 10, 2019

maximilien May 10, 2019

cppforlife May 10, 2019

maximilien May 10, 2019

cppforlife May 10, 2019

cppforlife commented May 10, 2019

maximilien commented May 10, 2019

cppforlife commented May 14, 2019

knative-prow-robot commented May 14, 2019

		In this basic worflow we show the CRUD (create, read, update, delete) operations on a service. We use a well known [simple Hello World service](https://github.com/knative/docs/tree/master/docs/serving/samples/hello-world/helloworld-go) that reads the environment variable `TARGET` and prints it as output.

		1. Create a service from image in `default` namespace

		## Basic (get your feet wet)

		In this basic worflow we show the CRUD (create, read, update, delete) operations on a service. We use a well known [simple Hello World service](https://github.com/knative/docs/tree/master/docs/serving/samples/hello-world/helloworld-go) that reads the environment variable `TARGET` and prints it as output.

		The purpose of this section of the Kn documentation is to list what we believe are common workflows or use-cases for the Knative CLI. Obviously, as we release the CLI in the wild and get users in production, we might discover novel workflows. As we do we will improve this document.

		## Basic (get your feet wet)

		# Workflows

		The purpose of this section of the Kn documentation is to list what we believe are common workflows or use-cases for the Knative CLI. Obviously, as we release the CLI in the wild and get users in production, we might discover novel workflows. As we do we will improve this document.

		```

		You can then issue the same `$ kn service list` command to verify that the service was deleted.


		```bash
		curl '-sS' '-H' 'Host: hello.default.example.com' 'http://xxx.xx.xxx.xx:80'

		```

		Where `http://xxx.xx.xxx.xx:80` is your Knative installation ingress.

Adds basic workflow #99

Adds basic workflow #99

Conversation

maximilien commented May 9, 2019

sixolet commented May 9, 2019

sixolet left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

maximilien May 10, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cppforlife commented May 10, 2019

maximilien commented May 10, 2019

cppforlife commented May 14, 2019

knative-prow-robot commented May 14, 2019

maximilien May 10, 2019 •

edited