Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration tests to match the Basic workflow #104

Closed
maximilien opened this issue May 13, 2019 · 5 comments · Fixed by #112
Closed

Add integration tests to match the Basic workflow #104

maximilien opened this issue May 13, 2019 · 5 comments · Fixed by #112

Comments

@maximilien
Copy link
Contributor

maximilien commented May 13, 2019

This should be structured as start of e2e tests and for the first cut cover the proposed Basic workflow. So includes:

  1. create service
  2. service get, service describe newly created service
  3. service list that service in in the list
  4. delete service and verify deleted

Subsequence e2e tests can follow additional advanced workflows with more commands, e.g., service update, service replace

@maximilien
Copy link
Contributor Author

Unless I hear otherwise, I will add this test and verify it on IKS to also have another additional platform for testing.

navidshaikh added a commit to navidshaikh/client that referenced this issue May 15, 2019
@navidshaikh
Copy link
Collaborator

@maximilien : I added few basic workflow commands in script, if you plan to address this in different way, please let me know.

@maximilien
Copy link
Contributor Author

Nice @navidshaikh. Thanks! I'll try it on IKS and submit any changes as needed. Cheers 🍻

@maximilien
Copy link
Contributor Author

maximilien commented May 15, 2019

While this is great to start with, I also wanted the tests to be written in Golang. I'll create small example and tee it up for next call so we can discuss.

However, what you have is fine for now and for v0.1 purposes --- especially since it follows what @sixolet had in the first e2e.

Cheers.

navidshaikh added a commit to navidshaikh/client that referenced this issue May 16, 2019
@maximilien
Copy link
Contributor Author

FYI: Once #112 is merged I will close this. I opened #114 for the Golang version discussion above.

knative-prow-robot pushed a commit that referenced this issue May 17, 2019
* Tests running simple workflow in e2e

 Fixes #104

* Adds e2e test for --force flag while creating service

 also removes http:// before the registry name

* Removes the update command

* Adds the service update command back to e2e tests

 also increases the sleep time between create and get
rhuss pushed a commit to rhuss/knative-client that referenced this issue May 27, 2019
* Tests running simple workflow in e2e

 Fixes knative#104

* Adds e2e test for --force flag while creating service

 also removes http:// before the registry name

* Removes the update command

* Adds the service update command back to e2e tests

 also increases the sleep time between create and get
maximilien pushed a commit to maximilien/client that referenced this issue May 28, 2019
* Tests running simple workflow in e2e

 Fixes knative#104

* Adds e2e test for --force flag while creating service

 also removes http:// before the registry name

* Removes the update command

* Adds the service update command back to e2e tests

 also increases the sleep time between create and get
navidshaikh pushed a commit to navidshaikh/client that referenced this issue Oct 1, 2019
Adds install target for Makefile to install kn
coryrc pushed a commit to coryrc/client that referenced this issue May 14, 2020
`run_lint_tool()` uses markdownlint as the lint tool.

Bonus: factor out running a linter against a set of files.

Part of knative#101.
dsimansk pushed a commit to dsimansk/client that referenced this issue Mar 17, 2023
* Helloworld image running with non root user

* Use release-1.28 branch from serverless-operator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants