New Repo: func

[lance]

Repo information

Org: knative-sandbox

Repo: func

Purpose (Description): The kn-plugin-func project was originally conceived as its own standalone CLI as well as a Go library. Its continued evolution has maintained this separation quite cleanly as func moved to knative-sandbox and became kn-plugin-func. We would like to formalize the separation of concerns, by extracting the Go library bits into its own GitHub repository where it can be maintained and versioned independent of its status as a plugin for kn.

Sponsoring WG: By the transitive property of Task Force to Working Group, the Client WG.

Actions to fulfill

This area is used to track the repo creation process.
The requestor and sponsoring WG lead should perform the steps listed below and cross out the checkmarks when done.
The TOC is involved only in the TOC Gate steps.

• Add this issue to the TOC project board for review. You are responsible for moving your entry on the board to "Needs Discussion" or "In Progress" as you move forward in this checklist.

You may not be able to use the Projects quick menu on this page. In that case, go to the project board and use the Add cards interface.

• Send a PR adding entries for this repo in /peribolos/knative-sandbox.yaml. Please mind the alphabetical order when adding to a list.
  • Add the repository and a description.
  • Grant Knative Admin the admin privilege.
  • Grant the sponsoring WG the write privilege.

TOC Gate: Once the TOC has approved the above, it will merge and Peribolos will create an empty repository.

• (golang) Send a PR to add aliases for knative.dev/$REPONAME import paths (sample).

• Have a lead from the sponsoring WG bootstrap the Git repository by pushing an
  appropriate "template" repository (basic,
  sample-controller,
  sample-source) to the new repository as
  a git remote. For example:

    git clone https://github.com/knative-sandbox/sample-controller.git
    cd sample-controller
    git remote add newrepo https://github.com/knative-sandbox/$REPONAME.git
    git push newrepo main

• Add your GitHub ID to the OWNERS file for your repo.

• Set up prow for a new repo

• Bootstrap your CI jobs using hack project (look at other sandbox repos for reference)

• Create a sample PR to verify Prow (e.g., edit the boilerplate README)

• Verify that within 24 hours the appropriate branch protections have been applied
  requiring tide to pass before PRs are merged.

• (optional) Send a PR adding the repo to knobots.

[evankanderson]

Should this go into client-pkg, or do we need another repo, like func-pkg?

It sounds like we don't want to pollute the dependencies of client-pkg with all the func stuff, so requesting a separate repo.

[evankanderson]

Roland suggests that we may want a litmus test of whether there's another user of this functionality. We've encountered this problem between pkg and serving and eventing where you have to develop in one repo, then update go modules in the other repo, and then finish your development.

With that said, the TOC is willing to approve this repo if it will help.

[lance]

Link to Slack discussion https://knative.slack.com/archives/CUU6LEMRT/p1639076443212900

[rhuss]

As mentioned, I'd prefer a repo name like func-pkg to emphasize its usage as a library (and does not contain a "func" binary thing)

[lance]

@evankanderson we were holding off closing this because func had not been set up in prow and we were not using knative build tooling. This is no longer the case. I think this could be closed now. wdyt?

[evankanderson]

SGTM!

/close

[knative-prow]

@evankanderson: Closing this issue.

In response to this:

SGTM!

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.