-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functions working group teams to peribolos #1091
Conversation
Signed-off-by: Lance Ball <lball@redhat.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
peribolos/knative.yaml
Outdated
teams: | ||
Func WG Leads: | ||
description: The Working Group Leads for Functions | ||
privacy: closed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you want to drop this nested team and add it in a separate PR
it's really annoying
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's really annoying
Yes! Yes it is! 😭
Signed-off-by: Lance Ball <lball@redhat.com>
Signed-off-by: Lance Ball <lball@redhat.com>
/retest |
/test pull-knative-peribolos |
|
/override pull-knative-peribolos |
@lance: Overrode contexts on behalf of lance: pull-knative-peribolos In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
/hold cancel |
This reverts commit f17b4bf.
Signed-off-by: Lance Ball lball@redhat.com
Seems to be required for: #1032