Minor fixes for SC election 2023 #1453
Conversation
knative-prow
bot
added
the
kind/cleanup
knative-prow
bot
added
approved
knative-prow
bot
removed
the
approved
| @@ -28,7 +28,7 @@ jobs: | |||
| name: Verify Deps and Codegen | |||
| strategy: | |||
| matrix: | |||
| go-version: [1.18.x] | |||
| go-version: [1.21.x] | |||
There was a problem hiding this comment.
This looks like maybe something you accidentally included in the PR? If you remove the change to this file, I can merge the PR with the changes to the elections files.
There was a problem hiding this comment.
Though, not relevant to the PR without it the GH-actions are broken and the PR will not pass CI checks (https://github.com/knative/community/actions/runs/6542752164). I could do that PR separately, but as we'd like to proceed with the announcement I think we also can keep it in one. WDYT?
There was a problem hiding this comment.
Aha, I see the reason now. However, we'll need someone from the @knative/technical-oversight-committee to merge this one, since they are the OWNERS for the .github dir. Maybe @dsimansk, since it looks like maybe David is in a European time zone :)
LGTM from an election standpoint.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dsimansk, ReToCode The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
|
Thank you for the PR @ReToCode 👍 |
Changes
/kind cleanup
/assign @knative/steering-committee