Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some extra explanation to new-repo issue template #263

Merged
merged 1 commit into from
Sep 28, 2020
Merged

Add some extra explanation to new-repo issue template #263

merged 1 commit into from
Sep 28, 2020

Conversation

rhuss
Copy link
Contributor

@rhuss rhuss commented Sep 9, 2020

No description provided.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 9, 2020
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 9, 2020
@rhuss rhuss mentioned this pull request Sep 9, 2020
Closed
10 tasks
mattmoor
mattmoor reviewed Sep 9, 2020
View reviewed changes
.github/ISSUE_TEMPLATE/new-repo.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/new-repo.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/new-repo.md Outdated Show resolved Hide resolved
@evankanderson
Copy link
Member

/assign @mattmoor

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 13, 2020
chaodaiG pushed a commit to chaodaiG/community that referenced this pull request Sep 15, 2020
@ramaraochavali @istio-testing
add Rama as Pilot maintainer (knative#263)
3919883 
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 26, 2020
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no Indicates the PR's author has not signed the CLA. and removed cla: yes Indicates the PR's author has signed the CLA. labels Sep 26, 2020
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Indicates the PR's author has signed the CLA. and removed cla: no Indicates the PR's author has not signed the CLA. labels Sep 26, 2020
@rhuss
Copy link
Contributor Author

rhuss commented Sep 26, 2020

@mattmoor addressed review comments and rebased.

mattmoor
mattmoor reviewed Sep 26, 2020
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2020
@bsnchan
Copy link
Contributor

bsnchan commented Sep 28, 2020

/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bsnchan, mattmoor, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 28, 2020
@knative-prow-robot knative-prow-robot merged commit a1e8735 into knative:master Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmoor mattmoor mattmoor left review comments

@bsnchan bsnchan Awaiting requested review from bsnchan

@lindydonna lindydonna Awaiting requested review from lindydonna

Assignees

@mattmoor mattmoor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rhuss @evankanderson @googlebot @bsnchan @knative-prow-robot @mattmoor