Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting the Github Source hangs #553

Closed
mattmoor opened this issue Nov 17, 2018 · 5 comments
Closed

Deleting the Github Source hangs #553

mattmoor opened this issue Nov 17, 2018 · 5 comments
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@mattmoor
Copy link
Member

kubectl delete githubsource.sources.eventing.knative.dev/githubsourcesample

It has a finalizer, so I'm guessing this isn't being handled properly.

@mattmoor
Copy link
Member Author

cc @evankanderson @vaikas-google

@mattmoor
Copy link
Member Author

This seems to happen even with --grace-period=0 --force.

I'm sort of at a loss, I'm a little worried about this resource sitting in purgatory and inhibiting my ability to experiment further without razing my cluster.

@mattmoor
Copy link
Member Author

I seem to have been able to delete it by kubectl edit + removing the finalizer. Hopefully this didn't leak anything important :)

@mattmoor
Copy link
Member Author

Now I see a webhook!

@RichieEscarez RichieEscarez added kind/bug Categorizes issue or PR as related to a bug. kind/enhancement labels Dec 19, 2018
@evankanderson
Copy link
Member

This looks like a duplicate of knative/eventing#672, which was fixed by knative/eventing-contrib#146.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

4 participants