Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A local registry is no longer created by default. #5778

Closed
gflarity opened this issue Nov 28, 2023 · 7 comments · Fixed by knative-extensions/kn-plugin-quickstart#498
Closed
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@gflarity
Copy link

There's a "bug" on this page:

https://knative.dev/docs/getting-started/quickstart-install/

kn quickstart kind will fail because registry is not created by default anymore.

Documentation fix:

kn quickstart kind --registry.

Looks like there's a whole process to contribute to docs, otherwise I would have just done that instead of filling a bug :)

@gflarity gflarity added the kind/bug Categorizes issue or PR as related to a bug. label Nov 28, 2023
@yanggangtony
Copy link

/assign

@ReToCode
Copy link
Member

ReToCode commented Dec 6, 2023

@knative/client-writers can we handle this in kn? It seems odd to add this to the docs, if we always need --registry anyways.

Copy link

github-actions bot commented Mar 6, 2024

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 6, 2024
@dprotaso
Copy link
Member

dprotaso commented Mar 7, 2024

cc @psschwei any thoughts here?

@psschwei
Copy link
Contributor

psschwei commented Mar 7, 2024

I'd lean towards not having to require passing a flag for the default setup to work (sort of contradicts the name quickstart in that case....) and just fix kn quickstart kind so that it doesn't fail. There was a PR in flight to fix this (knative-extensions/kn-plugin-quickstart#490 (review)), but looks like it's stalled a bit. I'll see if I can find some free cycles to take a look at it.

@psschwei
Copy link
Contributor

psschwei commented Mar 7, 2024

@dprotaso PR ^^^ should fix the issue without requiring any update to the docs.

@dprotaso
Copy link
Member

dprotaso commented Mar 7, 2024

PR merged - going to close this out

@dprotaso dprotaso closed this as completed Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
5 participants