Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using a larger default TTL until we make it settable. #1016

Merged
merged 2 commits into from
Apr 2, 2019

Conversation

n3wscott
Copy link
Contributor

@n3wscott n3wscott commented Apr 1, 2019

Proposed Changes

  • TTL was blocking me to make a cool app. Bumping TTL to a large number until we make it configurable.

Related to: #1011

Release Note

Increase TTL from 10 to 255.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 1, 2019
@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 1, 2019
@n3wscott
Copy link
Contributor Author

n3wscott commented Apr 1, 2019

assign @grantr

@matzew
Copy link
Member

matzew commented Apr 1, 2019 via email

@vaikas
Copy link
Contributor

vaikas commented Apr 2, 2019

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott, vaikas-google

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [n3wscott,vaikas-google]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 7e1bf9f into knative:master Apr 2, 2019
lberk pushed a commit to lberk/eventing that referenced this pull request Jan 12, 2021
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants