Propose retry channel behavior #1617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
the
size/S
Harwayne
reviewed
Aug 1, 2019
docs/spec/channel.md
Outdated
|
|
||
| Channels SHOULD retry resending CloudEvents when they fail to either connect or send CloudEvents to subscribers. | ||
|
|
||
| Channels SHOULD support various retry configuration parameters, including, but not limiting to: |
There was a problem hiding this comment.
Suggested change
| Channels SHOULD support various retry configuration parameters, including, but not limiting to: | |
| Channels SHOULD support various retry configuration parameters, including, but not limited to: |
There was a problem hiding this comment.
fixed. (didn't see the commit suggestion button. Next time!)
There was a problem hiding this comment.
Probably for the best, I think the CLA bot doesn't like it when you accept the suggestions (as they are attributed to the suggester).
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Harwayne, lionelvillard The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
aliok
pushed a commit
to aliok/eventing
that referenced
this pull request
Feb 15, 2022
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
@matzew @Harwayne @alanconway @aslom comments?