Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing some wording #4258

Merged

Conversation

matzew
Copy link
Member

@matzew matzew commented Oct 8, 2020

Signed-off-by: Matthias Wessendorf mwessend@redhat.com

On eventing-kafka, some lint, reported:

 reviewdog: This is Pull-Request from forked repository.
  reviewdog: found at least one result in diff
  GitHub token doesn't have write permission of Check API, so reviewdog will
  report results via logging command [1].
  [1]: https://help.github.com/en/actions/automating-your-workflow-with-github-actions/development-tools-for-github-actions#logging-commands
  reviewdog: Reporting results for "woke"
  Error: [woke] reported by reviewdog 🐶
  Error:  `dummy` may be insensitive, use `placeholder`, `sample` instead
  
  Raw Output:
  Error: knative.dev/eventing/test/test_images/performance/mako.config:5:25: [error] `dummy` may be insensitive, use `placeholder`, `sample` instead
  Error: Process completed with exit code 1.

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 8, 2020
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 8, 2020
@knative-prow-robot knative-prow-robot added area/performance area/test-and-release Test infrastructure, tests or release labels Oct 8, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2020
@travis-minke-sap
Copy link
Contributor

/lgtm

@knative-prow-robot
Copy link
Contributor

@travis-minke-sap: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@devguyio
Copy link
Contributor

devguyio commented Oct 8, 2020

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 8, 2020
@codecov
Copy link

codecov bot commented Oct 8, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@6bec338). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4258   +/-   ##
=========================================
  Coverage          ?   80.22%           
=========================================
  Files             ?      283           
  Lines             ?     7819           
  Branches          ?        0           
=========================================
  Hits              ?     6273           
  Misses            ?     1164           
  Partials          ?      382           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bec338...c37bae0. Read the comment docs.

@knative-prow-robot knative-prow-robot merged commit ce00668 into knative:master Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/performance area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants