New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add devguyio to approvers #4700
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4700 +/- ##
=======================================
Coverage 81.07% 81.07%
=======================================
Files 291 291
Lines 8216 8216
=======================================
Hits 6661 6661
Misses 1154 1154
Partials 401 401 Continue to review full report at Codecov.
|
Yeah you made it! :-) /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: devguyio, lionelvillard The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM ! Congrats @devguyio ! |
Seems I was sloppy yesterday when I created that approver PR. I used the filter from another approver PR without weeding through the PRs. (Some PRs were just comments, or review of proposals, not code base) Now that I did, I don't yet meet the criteria, I've 8 substantial PRs, and 19 total . I'll close the PR and reopen it when I meet the criteria. |
What should the right filter be? I think I am getting the similar filter too from #2118 I found some standard difficult to understand like "substantial", maybe we should put the filter in the doc too. WDYT? |
Update: I closed the PR until eligibility number is reached
Criteria from https://github.com/knative/community/blob/master/ROLES.md#approver
First review:
#491 , Oct 5th, 2018
Substantial PRs reviewed (size/L, size/XL and size/XXL): https://github.com/knative/eventing/pulls?q=is%3Apr+-author%3Adevguyio+commenter%3Adevguyio+-label%3Asize%2FS+-label%3Asize%2FXS+-label%3Asize%2FM+
9
PRs:
#491
#3266
#3313
#3325
#3362
#3431
#3472
#4460
#4832
20
#4832
#4640
#4478
#4460
#4434
#4258
#4109
#3472
#3431
#3406
#3362
#3341
#3325
#3313
#3269
#3266
#3077
#1552
#1520
#491
https://github.com/knative/eventing/pulls?q=is%3Apr+-author%3Adevguyio+commenter%3Adevguyio
Nominated by an area lead with no objections from other leads: