Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add devguyio to approvers #4700

Closed
wants to merge 1 commit into from
Closed

Conversation

devguyio
Copy link
Contributor

@devguyio devguyio commented Jan 6, 2021

Update: I closed the PR until eligibility number is reached

Criteria from https://github.com/knative/community/blob/master/ROLES.md#approver

Reviewer of the codebase for at least 3 months:

First review:
#491 , Oct 5th, 2018

Substantial PRs reviewed (size/L, size/XL and size/XXL): https://github.com/knative/eventing/pulls?q=is%3Apr+-author%3Adevguyio+commenter%3Adevguyio+-label%3Asize%2FS+-label%3Asize%2FXS+-label%3Asize%2FM+

Primary reviewer for at least 10 substantial PRs to the codebase.

9

PRs:
#491
#3266
#3313
#3325
#3362
#3431
#3472
#4460
#4832

Reviewed at least 30 PRs to the codebase

20

#4832
#4640
#4478
#4460
#4434
#4258
#4109
#3472
#3431
#3406
#3362
#3341
#3325
#3313
#3269
#3266
#3077
#1552
#1520
#491

https://github.com/knative/eventing/pulls?q=is%3Apr+-author%3Adevguyio+commenter%3Adevguyio

Nominated by an area lead with no objections from other leads:

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Jan 6, 2021
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 6, 2021
@devguyio devguyio requested review from grantr, vaikas and lionelvillard and removed request for aslom and liu-cong January 6, 2021 18:32
@codecov
Copy link

codecov bot commented Jan 6, 2021

Codecov Report

Merging #4700 (40e1cb2) into master (3f2d693) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4700   +/-   ##
=======================================
  Coverage   81.07%   81.07%           
=======================================
  Files         291      291           
  Lines        8216     8216           
=======================================
  Hits         6661     6661           
  Misses       1154     1154           
  Partials      401      401           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f2d693...40e1cb2. Read the comment docs.

@lionelvillard
Copy link
Member

Yeah you made it! :-)

/approve
LGTM

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: devguyio, lionelvillard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2021
@matzew
Copy link
Member

matzew commented Jan 7, 2021

LGTM ! Congrats @devguyio !

@devguyio
Copy link
Contributor Author

devguyio commented Jan 7, 2021

Seems I was sloppy yesterday when I created that approver PR. I used the filter from another approver PR without weeding through the PRs. (Some PRs were just comments, or review of proposals, not code base)

Now that I did, I don't yet meet the criteria, I've 8 substantial PRs, and 19 total .
I've updated the description to match the real status.

I'll close the PR and reopen it when I meet the criteria.

@devguyio devguyio closed this Jan 7, 2021
@zhongduo
Copy link
Contributor

What should the right filter be? I think I am getting the similar filter too from #2118

I found some standard difficult to understand like "substantial", maybe we should put the filter in the doc too. WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants