Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracing fixed for apiserversource #4842

Merged
merged 1 commit into from
Feb 11, 2021
Merged

tracing fixed for apiserversource #4842

merged 1 commit into from
Feb 11, 2021

Conversation

Shashankft9
Copy link
Member

@Shashankft9 Shashankft9 commented Feb 4, 2021

Fixes #
#1889

Proposed Changes

Release Note

Fix availability of zipkin traces for APIServerSource

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Feb 4, 2021
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 4, 2021
@knative-prow-robot
Copy link
Contributor

Hi @Shashankft9. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 4, 2021
@Shashankft9
Copy link
Member Author

cc @Harwayne

@codecov
Copy link

codecov bot commented Feb 4, 2021

Codecov Report

Merging #4842 (49421ca) into master (152e608) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4842   +/-   ##
=======================================
  Coverage   81.32%   81.32%           
=======================================
  Files         292      292           
  Lines        8322     8322           
=======================================
  Hits         6768     6768           
  Misses       1145     1145           
  Partials      409      409           
Impacted Files Coverage Δ
pkg/adapter/v2/config.go 59.64% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 152e608...b0a1fb1. Read the comment docs.

@tommyreddad
Copy link
Contributor

/ok-to-test

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 4, 2021
@tommyreddad
Copy link
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2021
@Shashankft9
Copy link
Member Author

hmm what more do we need to send this through?

@pierDipi
Copy link
Member

/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi, Shashankft9

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 11, 2021
@pierDipi
Copy link
Member

@Shashankft9 can you add a release note?
/kind bug

@knative-prow-robot knative-prow-robot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 11, 2021
@knative-prow-robot knative-prow-robot merged commit d7cf344 into knative:master Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants