Setting tracing config for PingSource

[Shashankft9]

Fixes
#4757

Proposed Changes

• reading config-tracing cm and setting it for the pingsource adapter

Release Note

Cloudevent traces available for PingSource

Docs
knative/docs#3249

[knative-prow-robot]

Hi @Shashankft9. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[antoineco]

Sounds reasonable but it feels to me like we should use the config helper instead of manually handling each ConfigMap.

A hint for the implementation, in case you're willing to tackle it in this PR (I think it would greatly simplify the code);

// reconciler/controller.go

import (
	"knative.dev/eventing/pkg/reconciler/source"
)

// ...

&Reconciler{
	adapterConfigs: source.WatchConfigurations(ctx, "pingsource", cmw),
}

// resources/receive_adapter.go

env = append(env, args.Configs.ToEnvVars()...))

[codecov]

Codecov Report

Merging #4877 (c3985b0) into master (1c771ce) will decrease coverage by 0.00%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##           master    #4877      +/-   ##
==========================================
- Coverage   81.35%   81.34%   -0.01%     
==========================================
  Files         292      292              
  Lines        8322     8329       +7     
==========================================
+ Hits         6770     6775       +5     
- Misses       1144     1145       +1     
- Partials      408      409       +1     

Impacted Files	Coverage Δ
pkg/reconciler/pingsource/pingsource.go	58.10% <50.00%> (-0.47%)	⬇️
...reconciler/pingsource/resources/receive_adapter.go	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c771ce...e4c1a29. Read the comment docs.

[Shashankft9]

@antoineco mhm I can try refactoring, but maybe in a separate PR? I will try next week, but if not, atleast the traces will be available in 0.21 release. Makes sense?

[antoineco]

I don't mind that but it would actually be less lines of code to implement that change, that's why I was suggesting it.

/ok-to-test

[antoineco]

One small comment. Otherwise LGTM 👍

[antoineco]

/lgtm

[knative-metrics-robot]

The following is the coverage report on the affected files.
Say /test pull-knative-eventing-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pingsource/pingsource.go	63.2%	63.3%	0.2

[lionelvillard]

/approve

@Shashankft9 do you mind opening an issue to use the config helper as @antoineco suggested?

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: antoineco, lionelvillard, Shashankft9

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [lionelvillard]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[antoineco]

@lionelvillard I'll send a PR with that change right after this gets merged (it's already done)

[Shashankft9]

@antoineco you can open the PR, since it does the same thing but in a better way, would be nice to get that merged instead of this 🤔

[antoineco]

@Shashankft9 it's fine, logical steps are also good when reviewing the commit history 👍