-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance DLQ CloudEvents with destination #5727
Enhance DLQ CloudEvents with destination #5727
Conversation
Hi @travis-minke-sap. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## main #5727 +/- ##
==========================================
+ Coverage 82.68% 82.69% +0.01%
==========================================
Files 200 200
Lines 6261 6265 +4
==========================================
+ Hits 5177 5181 +4
Misses 750 750
Partials 334 334
Continue to review full report at Codecov.
|
/ok-to-test
|
/lgtm |
The following is the coverage report on the affected files.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew, travis-minke-sap The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #5726
Proposed Changes
destination
orreply
URL in newknativeerrordest
extension attribute.Pre-review Checklist
Release Note
Docs
See documentation PR #4228