Channel Input Conformance Tests

[vishal-chdhry]

Part of #5782

Proposed Changes

• Fixes unimplimented input tests in channel dataplane

Pre-review Checklist

• At least 80% unit test coverage
• E2E tests for any new behavior
• Docs PR for any user-facing impact
• Spec PR for any new API feature
• Conformance test for any change to the spec

Release Note

Fixed Dataplane conformance  unimplemented test cases.

Docs

[knative-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Vishal-Chdhry
Once this PR has been reviewed and has the lgtm label, please assign psschwei for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• test/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[knative-prow]

Hi @vishal-chdhry. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[vishal-chdhry]

@pierDipi

These two tests

eventing/test/rekt/features/channel/data_plane.go

Lines 66 to 67 in f361a57

	May("The HTTP(S) endpoint MAY be on any port, not just the standard 80 and 443.", todo).
	May("Channels MAY expose other, non-HTTP endpoints in addition to HTTP at their discretion.", todo)

are marked as icebox in broker dataplane as well, should they be marked as icebox here as well?

eventing/test/rekt/features/broker/data_plane.go

Lines 93 to 96 in f361a57

	May("The HTTP(S) endpoint MAY be on any port, not just the standard 80 and 443.",
	icebox).
	May("Channels MAY expose other, non-HTTP endpoints in addition to HTTP at their discretion.",
	icebox)

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: -0.06 ⚠️

Comparison is base (f361a57) 80.46% compared to head (fe5bdf5) 80.40%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6823      +/-   ##
==========================================
- Coverage   80.46%   80.40%   -0.06%     
==========================================
  Files         236      236              
  Lines       12237    12243       +6     
==========================================
- Hits         9846     9844       -2     
- Misses       1899     1907       +8     
  Partials      492      492              

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[github-actions]

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.