Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscription Conformance Tests completion #5782

Open
gabo1208 opened this issue Oct 4, 2021 · 15 comments
Open

Subscription Conformance Tests completion #5782

gabo1208 opened this issue Oct 4, 2021 · 15 comments
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature-request triage/accepted Issues which should be fixed (post-triage)

Comments

@gabo1208
Copy link
Member

gabo1208 commented Oct 4, 2021

Problem
We don't have all the MUST clauses in the Subscription spec covered by tests in the project, for example:
https://github.com/knative/eventing/blob/792f56ddb5e2328005149e7af571be6ca667cd89/test/rekt/features/channel/data_plane.go lots of todo in .must clauses in this file.
Same with the other CRDs (Subscription, Broker, Trigger)

Persona:
Developers

Exit Criteria
Have at least one test per MUST clause from the Subscription specs

Additional context (optional)
This is part of the Conformance GA plan

@gabo1208 gabo1208 changed the title Triggers Conformance Tests completion Subscription Conformance Tests completion Oct 4, 2021
@github-actions
Copy link

github-actions bot commented Jan 3, 2022

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 3, 2022
@pierDipi
Copy link
Member

pierDipi commented Jan 3, 2022

/remove-lifecycle stale
/triage accepted

@knative-prow-robot knative-prow-robot added triage/accepted Issues which should be fixed (post-triage) and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 3, 2022
@daisy-ycguo
Copy link
Member

Who can add more details of this issue?
What kind of tests? Does it mean to add unit tests or validation tests?
What's MUST cause in subscription spec? It will be helpful to add a link to a "MUST cause" sample here.
Thanks.

@gabo1208
Copy link
Member Author

Yep, edited the issue with more context =)

@daisy-ycguo
Copy link
Member

I'm working on broker's conformance tests.
/assign

@daisy-ycguo
Copy link
Member

@gabo1208 will you check if my PR satisfied your requeirments? If it is, I could provide more conformance tests.

@gabo1208
Copy link
Member Author

gabo1208 commented Jul 5, 2022

Of course tomorrow morning I'll check it out :) thanks for the ping @daisy-ycguo

@pierDipi
Copy link
Member

/good-first-issue

I'd recommend to split the solution for this issue in multiple PRs, one for each scenario

@knative-prow
Copy link

knative-prow bot commented Mar 17, 2023

@pierDipi:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

I'd recommend to split the solution for this issue in multiple PRs, one for each scenario

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Mar 17, 2023
@garg-dhruv
Copy link

/assign

@vishal-chdhry
Copy link
Member

@gabo1208 I am working on Broker Conformance tests and Channel Input tests

@ThatSneakyCoder
Copy link

/assign

@ThatSneakyCoder ThatSneakyCoder removed their assignment Jul 13, 2023
ThatSneakyCoder added a commit to ThatSneakyCoder/eventing that referenced this issue Jul 13, 2023
@pierDipi pierDipi removed the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Jan 15, 2024
@sadath-12
Copy link
Contributor

/assign

@sadath-12
Copy link
Contributor

sadath-12 commented Jan 19, 2024

@gabo1208 shall I take the responsibility of filling all the todo's there into 2 pr's addDataPlaneDelivery and observability

@gabo1208
Copy link
Member Author

Ideally yes, but any progress is appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature-request triage/accepted Issues which should be fixed (post-triage)
Projects
None yet
Development

No branches or pull requests

8 participants