-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JobSink: Test OIDC support #8000
Conversation
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
/cc @creydr |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8000 +/- ##
==========================================
+ Coverage 67.65% 67.72% +0.06%
==========================================
Files 361 362 +1
Lines 16638 16720 +82
==========================================
+ Hits 11256 11323 +67
- Misses 4690 4701 +11
- Partials 692 696 +4 ☔ View full report in Codecov by Sentry. |
@pierDipi is this a (known) flake? /test reconciler-tests EDIT: |
ac44e0c
to
5bacd0d
Compare
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
5bacd0d
to
2ef1580
Compare
I don't get why this
is not matched with:
|
This is why
|
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
4971021
to
e93d08f
Compare
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
finally 🎉
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #
Proposed Changes
Pre-review Checklist
Release Note
Docs